From 122f6cc11888635a5a5e42583c28f0f79c23bde0 Mon Sep 17 00:00:00 2001 From: "Juergen E. Fischer" Date: Mon, 24 Feb 2014 14:05:11 +0100 Subject: [PATCH] oracle provider: replace rownum=0 with 1=0 to retrieve columns (fixes #9633) --- src/providers/oracle/qgsoracleprovider.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/providers/oracle/qgsoracleprovider.cpp b/src/providers/oracle/qgsoracleprovider.cpp index 011d585efb83..a65654aaa174 100644 --- a/src/providers/oracle/qgsoracleprovider.cpp +++ b/src/providers/oracle/qgsoracleprovider.cpp @@ -706,7 +706,7 @@ bool QgsOracleProvider::loadFields() mEnabledCapabilities |= QgsVectorDataProvider::CreateSpatialIndex; } - if ( !exec( qry, QString( "SELECT * FROM %1 WHERE rownum=0" ).arg( mQuery ) ) ) + if ( !exec( qry, QString( "SELECT * FROM %1 WHERE 1=0" ).arg( mQuery ) ) ) { QgsMessageLog::logMessage( tr( "Retrieving fields from '%1' failed [%2]" ).arg( mQuery ).arg( qry.lastError().text() ), tr( "Oracle" ) ); return false; @@ -835,7 +835,7 @@ bool QgsOracleProvider::hasSufficientPermsAndCapabilities() .arg( mQuery ) .arg( quotedIdentifier( alias ) ); - if ( !exec( qry, QString( "SELECT * FROM %1 WHERE rownum=0" ).arg( mQuery ) ) ) + if ( !exec( qry, QString( "SELECT * FROM %1 WHERE 1=0" ).arg( mQuery ) ) ) { QgsMessageLog::logMessage( tr( "Unable to execute the query.\nThe error message from the database was:\n%1.\nSQL: %2" ) .arg( qry.lastError().text() ) @@ -1906,7 +1906,7 @@ bool QgsOracleProvider::setSubsetString( QString theSQL, bool updateFeatureCount sql += "(" + mSqlWhereClause + ") AND "; } - sql += "rownum=0"; + sql += "1=0"; QSqlQuery qry( *mConnection ); if ( !exec( qry, sql ) ) @@ -2074,7 +2074,7 @@ bool QgsOracleProvider::getGeometryDetails() QSqlQuery qry( *mConnection ); if ( mIsQuery ) { - if ( !exec( qry, QString( "SELECT %1 FROM %2 WHERE rownum=0" ).arg( quotedIdentifier( mGeometryColumn ) ).arg( mQuery ) ) ) + if ( !exec( qry, QString( "SELECT %1 FROM %2 WHERE 1=0" ).arg( quotedIdentifier( mGeometryColumn ) ).arg( mQuery ) ) ) { QgsMessageLog::logMessage( tr( "Could not execute query.\nThe error message from the database was:\n%1.\nSQL: %2" ) .arg( qry.lastError().text() )