Skip to content
Permalink
Browse files

Make intention of comment a bit clearer

  • Loading branch information
nyalldawson committed Dec 11, 2018
1 parent 1921181 commit 12b3e15e78aae3d700f0a487a77163ce48e20fd4
Showing with 2 additions and 1 deletion.
  1. +2 −1 src/core/layout/qgslayoutexporter.cpp
@@ -1026,7 +1026,8 @@ QgsLayoutExporter::ExportResult QgsLayoutExporter::exportToSvg( QgsAbstractLayou
void QgsLayoutExporter::preparePrintAsPdf( QgsLayout *layout, QPrinter &printer, const QString &filePath )
{
printer.setOutputFileName( filePath );
// setOutputFormat should come after setOutputFileName, which auto-sets format to QPrinter::PdfFormat.
// setOutputFormat MUST come after setOutputFileName, which auto-sets format to QPrinter::PdfFormat.

// [LS] This should be QPrinter::NativeFormat for Mac, otherwise fonts are not embed-able
// and text is not searchable; however, there are several bugs with <= Qt 4.8.5, 5.1.1, 5.2.0:
// https://bugreports.qt.io/browse/QTBUG-10094 - PDF font embedding fails

0 comments on commit 12b3e15

Please sign in to comment.
You can’t perform that action at this time.