Make Select by Form default instead of By Expression

Since it's more user-friendly for beginners

Author: nyalldawson

src/app/qgisapp.cpp

@@ -2112,10 +2112,10 @@ void QgisApp::createToolBars()
   QToolButton *bt = new QToolButton( mAttributesToolBar );
   bt->setPopupMode( QToolButton::MenuButtonPopup );
   QList<QAction*> selectActions;
-  selectActions << mActionSelectByExpression << mActionSelectByForm << mActionSelectAll
+  selectActions << mActionSelectByForm << mActionSelectByExpression << mActionSelectAll
   << mActionInvertSelection;
   bt->addActions( selectActions );
-  bt->setDefaultAction( mActionSelectByExpression );
+  bt->setDefaultAction( mActionSelectByForm );
   QAction* selectionAction = mAttributesToolBar->insertWidget( mActionDeselectAll, bt );
   selectionAction->setObjectName( QStringLiteral( "ActionSelection" ) );
 

src/ui/qgisapp.ui

@@ -72,8 +72,8 @@
      <addaction name="mActionSelectPolygon"/>
      <addaction name="mActionSelectFreehand"/>
      <addaction name="mActionSelectRadius"/>
-     <addaction name="mActionSelectByExpression"/>
      <addaction name="mActionSelectByForm"/>
+     <addaction name="mActionSelectByExpression"/>
      <addaction name="mActionDeselectAll"/>
      <addaction name="mActionSelectAll"/>
      <addaction name="mActionInvertSelection"/>