Skip to content
Permalink
Browse files

Regenerate legend renderer tests using a bold font, and fix too

large number of tolerance pixels in tests

The previous reference images all used such a narrow reference font
that they required a very large pixel tolerance, which was letting
through real errors.

As a result disable the json opacity test, which was completely
broken ever since it was introduced. The test had a LARGER number
of tolerance pixels than the reference images had, and accordingly
was testing nothing at all. And the issue hasn't been fixed, so
the test was a false positive... Now the test is fixed but failing
and disabled, pending someone (else) fixing the underlying issue.
  • Loading branch information
nyalldawson committed May 5, 2020
1 parent afbb204 commit 1653bb80ab55387428260e74802b85902802f839
Showing with 51 additions and 36 deletions.
  1. +51 −36 tests/src/core/testqgslegendrenderer.cpp
  2. BIN tests/testdata/control_images/legend/expected_legend_2_by_2/expected_legend_2_by_2.png
  3. BIN tests/testdata/control_images/legend/expected_legend_2_by_2/expected_legend_2_by_2_mask.png
  4. BIN tests/testdata/control_images/legend/expected_legend_3_by_2/expected_legend_3_by_2.png
  5. BIN tests/testdata/control_images/legend/expected_legend_3_by_2/expected_legend_3_by_2_mask.png
  6. BIN tests/testdata/control_images/legend/expected_legend_3_by_3/expected_legend_3_by_3.png
  7. BIN tests/testdata/control_images/legend/expected_legend_3_by_3/expected_legend_3_by_3_mask.png
  8. BIN tests/testdata/control_images/legend/expected_legend_4_by_2/expected_legend_4_by_2.png
  9. BIN tests/testdata/control_images/legend/expected_legend_4_by_2/expected_legend_4_by_2_mask.png
  10. BIN tests/testdata/control_images/legend/expected_legend_4_by_3/expected_legend_4_by_3.png
  11. BIN tests/testdata/control_images/legend/expected_legend_4_by_3/expected_legend_4_by_3_mask.png
  12. BIN tests/testdata/control_images/legend/expected_legend_5_by_2/expected_legend_5_by_2.png
  13. BIN tests/testdata/control_images/legend/expected_legend_5_by_2/expected_legend_5_by_2_mask.png
  14. BIN tests/testdata/control_images/legend/expected_legend_5_by_3/expected_legend_5_by_3.png
  15. BIN tests/testdata/control_images/legend/expected_legend_5_by_3/expected_legend_5_by_3_mask.png
  16. BIN tests/testdata/control_images/legend/expected_legend_6_by_3/expected_legend_6_by_3.png
  17. BIN tests/testdata/control_images/legend/expected_legend_6_by_3/expected_legend_6_by_3_mask.png
  18. BIN tests/testdata/control_images/legend/expected_legend_7_by_3/expected_legend_7_by_3.png
  19. BIN tests/testdata/control_images/legend/expected_legend_7_by_3/expected_legend_7_by_3_mask.png
  20. BIN tests/testdata/control_images/legend/expected_legend_basic/expected_legend_basic.png
  21. BIN tests/testdata/control_images/legend/expected_legend_basic/expected_legend_basic_mask.png
  22. BIN tests/testdata/control_images/legend/expected_legend_big_marker/expected_legend_big_marker.png
  23. BIN tests/testdata/control_images/legend/expected_legend_big_marker/expected_legend_big_marker_mask.png
  24. BIN ...ata/control_images/legend/expected_legend_center_align_text/expected_legend_center_align_text.png
  25. BIN ...egend/expected_legend_data_defined_size_collapsed/expected_legend_data_defined_size_collapsed.png
  26. BIN ...a/control_images/legend/expected_legend_diagram_attributes/expected_legend_diagram_attributes.png
  27. BIN ...trol_images/legend/expected_legend_diagram_attributes/expected_legend_diagram_attributes_mask.png
  28. BIN tests/testdata/control_images/legend/expected_legend_diagram_size/expected_legend_diagram_size.png
  29. BIN ...testdata/control_images/legend/expected_legend_diagram_size/expected_legend_diagram_size_mask.png
  30. BIN tests/testdata/control_images/legend/expected_legend_effects/expected_legend_effects.png
  31. BIN tests/testdata/control_images/legend/expected_legend_effects/expected_legend_effects_mask.png
  32. BIN ...ntrol_images/legend/expected_legend_filter_by_expression/expected_legend_filter_by_expression.png
  33. BIN ..._images/legend/expected_legend_filter_by_expression/expected_legend_filter_by_expression_mask.png
  34. BIN ...rol_images/legend/expected_legend_filter_by_expression2/expected_legend_filter_by_expression2.png
  35. BIN ...mages/legend/expected_legend_filter_by_expression2/expected_legend_filter_by_expression2_mask.png
  36. BIN tests/testdata/control_images/legend/expected_legend_filter_by_map/expected_legend_filter_by_map.png
  37. BIN ...stdata/control_images/legend/expected_legend_filter_by_map/expected_legend_filter_by_map_mask.png
  38. BIN ...a/control_images/legend/expected_legend_filter_by_map_dupe/expected_legend_filter_by_map_dupe.png
  39. BIN ...trol_images/legend/expected_legend_filter_by_map_dupe/expected_legend_filter_by_map_dupe_mask.png
  40. BIN ...ata/control_images/legend/expected_legend_filter_by_polygon/expected_legend_filter_by_polygon.png
  41. BIN ...ontrol_images/legend/expected_legend_filter_by_polygon/expected_legend_filter_by_polygon_mask.png
  42. BIN ...a/control_images/legend/expected_legend_filter_by_polygon2/expected_legend_filter_by_polygon2.png
  43. BIN ...trol_images/legend/expected_legend_filter_by_polygon2/expected_legend_filter_by_polygon2_mask.png
  44. BIN ...rol_images/legend/expected_legend_group_heading_spacing/expected_legend_group_heading_spacing.png
  45. BIN ...rol_images/legend/expected_legend_left_align_side_space/expected_legend_left_align_side_space.png
  46. BIN ...mages/legend/expected_legend_left_align_side_space/expected_legend_left_align_side_space_mask.png
  47. BIN tests/testdata/control_images/legend/expected_legend_line_spacing/expected_legend_line_spacing.png
  48. BIN ...testdata/control_images/legend/expected_legend_line_spacing/expected_legend_line_spacing_mask.png
  49. BIN ...tdata/control_images/legend/expected_legend_long_symbol_text/expected_legend_long_symbol_text.png
  50. BIN .../control_images/legend/expected_legend_long_symbol_text/expected_legend_long_symbol_text_mask.png
  51. BIN tests/testdata/control_images/legend/expected_legend_mapunits/expected_legend_mapunits.png
  52. BIN tests/testdata/control_images/legend/expected_legend_mapunits/expected_legend_mapunits_mask.png
  53. BIN tests/testdata/control_images/legend/expected_legend_multiline/expected_legend_multiline.png
  54. BIN tests/testdata/control_images/legend/expected_legend_override_size/expected_legend_override_size.png
  55. BIN ...stdata/control_images/legend/expected_legend_override_size/expected_legend_override_size_mask.png
  56. BIN tests/testdata/control_images/legend/expected_legend_raster_border/expected_legend_raster_border.png
  57. BIN ...stdata/control_images/legend/expected_legend_raster_border/expected_legend_raster_border_mask.png
  58. BIN ...l_images/legend/expected_legend_right_align_side_space/expected_legend_right_align_side_space.png
  59. BIN ...tdata/control_images/legend/expected_legend_right_align_text/expected_legend_right_align_text.png
  60. BIN ...expected_legend_right_symbol_center_align_text/expected_legend_right_symbol_center_align_text.png
  61. BIN ...end/expected_legend_right_symbol_left_align_text/expected_legend_right_symbol_left_align_text.png
  62. BIN ...d/expected_legend_right_symbol_right_align_text/expected_legend_right_symbol_right_align_text.png
  63. BIN tests/testdata/control_images/legend/expected_legend_tall_symbol/expected_legend_tall_symbol.png
  64. BIN ...s/testdata/control_images/legend/expected_legend_tall_symbol/expected_legend_tall_symbol_mask.png
  65. BIN .../testdata/control_images/legend/expected_legend_text_on_symbol/expected_legend_text_on_symbol.png
  66. BIN tests/testdata/control_images/legend/expected_legend_three_columns/expected_legend_three_columns.png
  67. BIN ...stdata/control_images/legend/expected_legend_three_columns/expected_legend_three_columns_mask.png
  68. BIN .../legend/expected_legend_two_cols_center_align_text/expected_legend_two_cols_center_align_text.png
  69. BIN ..._align_symbol_center_align_text/expected_legend_two_cols_right_align_symbol_center_align_text.png
  70. BIN ...ight_align_symbol_left_align_text/expected_legend_two_cols_right_align_symbol_left_align_text.png
  71. BIN ...ht_align_symbol_right_align_text/expected_legend_two_cols_right_align_symbol_right_align_text.png
  72. BIN ...es/legend/expected_legend_two_cols_right_align_text/expected_legend_two_cols_right_align_text.png
  73. BIN tests/testdata/control_images/legend/expected_line_layer_icon/expected_line_layer_icon.png

Large diffs are not rendered by default.

Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.

0 comments on commit 1653bb8

Please sign in to comment.
You can’t perform that action at this time.