Skip to content

Commit 171dfe1

Browse files
committed
Retry WMS/WMTS/XYZ requests only on timeout (fixes #15854)
It does not really make sense to retry if server returns 404 Not Found or similar...
1 parent a18066b commit 171dfe1

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/providers/wms/qgswmsprovider.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3922,8 +3922,6 @@ void QgsWmsTiledImageDownloadHandler::tileReplyFinished()
39223922
{
39233923
QgsMessageLog::logMessage( tr( "Returned image is flawed [Content-Type:%1; URL: %2]" )
39243924
.arg( contentType, reply->url().toString() ), tr( "WMS" ) );
3925-
3926-
repeatTileRequest( reply->request() );
39273925
}
39283926
}
39293927
else
@@ -3948,7 +3946,9 @@ void QgsWmsTiledImageDownloadHandler::tileReplyFinished()
39483946
QgsWmsStatistics::Stat& stat = QgsWmsStatistics::statForUri( mProviderUri );
39493947
stat.errors++;
39503948

3951-
repeatTileRequest( reply->request() );
3949+
// if we reached timeout, let's try again (e.g. in case of slow connection or slow server)
3950+
if ( reply->error() == QNetworkReply::TimeoutError )
3951+
repeatTileRequest( reply->request() );
39523952
}
39533953
}
39543954

0 commit comments

Comments
 (0)