Fix Coverity uninitialized variable warnings

qgis · Oct 1, 2016 · 17db101 · 17db101
1 parent ffaffad
commit 17db101
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 9 deletions.
diff --git a/src/core/qgsattributeeditorelement.h b/src/core/qgsattributeeditorelement.h
@@ -313,7 +313,10 @@ class CORE_EXPORT QgsAttributeEditorRelation : public QgsAttributeEditorElement
     QgsAttributeEditorRelation( const QString& name, const QgsRelation& relation, QgsAttributeEditorElement* parent )
         : QgsAttributeEditorElement( AeTypeRelation, name, parent )
         , mRelationId( relation.id() )
-        , mRelation( relation ) {}
+        , mRelation( relation )
+        , mShowLinkButton( true )
+        , mShowUnlinkButton( true )
+    {}
 
     //! Destructor
     virtual ~QgsAttributeEditorRelation() {}

diff --git a/src/gui/qgsunitselectionwidget.cpp b/src/gui/qgsunitselectionwidget.cpp
@@ -125,6 +125,7 @@ QgsMapUnitScale QgsMapUnitScaleWidget::mapUnitScale() const
 
 QgsUnitSelectionWidget::QgsUnitSelectionWidget( QWidget *parent )
     : QWidget( parent )
+    , mCanvas( nullptr )
 {
   mMapUnitIdx = -1;
 

diff --git a/src/plugins/grass/qgsgrassregion.cpp b/src/plugins/grass/qgsgrassregion.cpp
@@ -200,6 +200,7 @@ QgsGrassRegion::QgsGrassRegion( QgisInterface *iface,
     , mRegionEdit( 0 )
 {
   QgsDebugMsg( "QgsGrassRegion()" );
+  QgsGrass::initRegion( &mWindow );
 
   setupUi( this );
   setAttribute( Qt::WA_DeleteOnClose );

diff --git a/src/providers/grass/qgsgrass.cpp b/src/providers/grass/qgsgrass.cpp
@@ -1686,14 +1686,14 @@ bool QgsGrass::writeRegion( const QString& gisbase,
                             const QString& location, const QString& mapset,
                             const struct Cell_head *window )
 {
-  QgsDebugMsg( QString( "n = %1 s = %2" ).arg( window->north ).arg( window->south ) );
-  QgsDebugMsg( QString( "e = %1 w = %2" ).arg( window->east ).arg( window->west ) );
-
   if ( !window )
   {
     return false;
   }
 
+  QgsDebugMsg( QString( "n = %1 s = %2" ).arg( window->north ).arg( window->south ) );
+  QgsDebugMsg( QString( "e = %1 w = %2" ).arg( window->east ).arg( window->west ) );
+
   QgsGrass::setMapset( gisbase, location, mapset );
 
   if ( G_put_window( window ) == -1 )

diff --git a/src/providers/oracle/ocispatial/wkbptr.h b/src/providers/oracle/ocispatial/wkbptr.h
@@ -52,6 +52,15 @@ enum SDO_GTYPE_TT
 class QOCISpatialGeometry : public QSharedData
 {
   public:
+    QOCISpatialGeometry()
+        : isNull( true )
+        , gtype( -1 )
+        , srid( -1 )
+        , x( 0.0 )
+        , y( 0.0 )
+        , z( 0.0 )
+    {}
+
     bool isNull;
     int gtype;
     int srid;

diff --git a/src/providers/wms/qgswmsprovider.cpp b/src/providers/wms/qgswmsprovider.cpp
@@ -1218,6 +1218,7 @@ void QgsWmsProvider::setupXyzCapabilities( const QString &uri )
     tm.tileWidth = tm.tileHeight = 256;
     tm.matrixWidth = tm.matrixHeight = 1 << zoom;
     tm.tres = xspan / ( tm.tileWidth * tm.matrixWidth );
+    tm.scaleDenom = 0.0;
 
     mCaps.mTileMatrixSets[tms.identifier].tileMatrices[tm.tres] = tm;
   }
@@ -3518,6 +3519,7 @@ QGISEXTERN bool isProvider()
 
 QgsWmsImageDownloadHandler::QgsWmsImageDownloadHandler( const QString& providerUri, const QUrl& url, const QgsWmsAuthorization& auth, QImage* image, QgsRasterBlockFeedback* feedback )
     : mProviderUri( providerUri )
+    , mCacheReply( nullptr )
     , mCachedImage( image )
     , mEventLoop( new QEventLoop )
     , mFeedback( feedback )

diff --git a/src/server/qgsserverlogger.cpp b/src/server/qgsserverlogger.cpp
@@ -34,7 +34,9 @@ QgsServerLogger* QgsServerLogger::instance()
   return mInstance;
 }
 
-QgsServerLogger::QgsServerLogger(): mLogFile( nullptr )
+QgsServerLogger::QgsServerLogger()
+    : mLogFile( nullptr )
+    , mLogLevel( 3 )
 {
   //logfile
   QString filePath = getenv( "QGIS_SERVER_LOG_FILE" );
@@ -53,10 +55,6 @@ QgsServerLogger::QgsServerLogger(): mLogFile( nullptr )
   {
     mLogLevel = atoi( logLevelChar );
   }
-  else
-  {
-    mLogLevel = 3;
-  }
 
   connect( QgsMessageLog::instance(), SIGNAL( messageReceived( QString, QString, QgsMessageLog::MessageLevel ) ), this,
            SLOT( logMessage( QString, QString, QgsMessageLog::MessageLevel ) ) );