Iterate over const

elpaso · elpaso · commit 1ab20bd7e930 · 2017-11-13T11:29:42.000+01:00
diff --git a/src/gui/qgsdatasourcemanagerdialog.cpp b/src/gui/qgsdatasourcemanagerdialog.cpp
@@ -60,7 +60,7 @@ QgsDataSourceManagerDialog::QgsDataSourceManagerDialog( QgsBrowserModel *browser
 
   // Add provider dialogs
   const QList<QgsSourceSelectProvider *> sourceSelectProviders = QgsGui::sourceSelectProviderRegistry()->providers( );
-  for ( const auto provider : sourceSelectProviders )
+  for ( const auto &provider : sourceSelectProviders )
   {
     QgsAbstractDataSourceWidget *dlg = provider->createDataSourceWidget( this );
     if ( !dlg )

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ QgsDataSourceManagerDialog::QgsDataSourceManagerDialog( QgsBrowserModel *browser`
`60`	`60`
`61`	`61`	`// Add provider dialogs`
`62`	`62`	`const QList<QgsSourceSelectProvider *> sourceSelectProviders = QgsGui::sourceSelectProviderRegistry()->providers( );`
`63`		`- for ( const auto provider : sourceSelectProviders )`
	`63`	`+ for ( const auto &provider : sourceSelectProviders )`
`64`	`64`	`{`
`65`	`65`	`QgsAbstractDataSourceWidget *dlg = provider->createDataSourceWidget( this );`
`66`	`66`	`if ( !dlg )`