No need to create a copy of the vector - a ref will do

g_j_m · g_j_m · commit 1b7780278a07 · 2006-04-08T05:22:12.000Z
git-svn-id: http://svn.osgeo.org/qgis/trunk@5224 c8812cc2-4d05-0410-92ff-de0c093fc19c
diff --git a/src/gui/qgsattributetable.cpp b/src/gui/qgsattributetable.cpp
@@ -506,7 +506,7 @@ void QgsAttributeTable::putFeatureInTable(int row, QgsFeature* fet)
   int id = fet->featureId();
   setText(row, 0, QString::number(id));
   insertFeatureId(id, row);  //insert the id into the search tree of qgsattributetable
-  std::vector < QgsFeatureAttribute > attr = fet->attributeMap();
+  const std::vector < QgsFeatureAttribute >& attr = fet->attributeMap();
   for (int i = 0; i < attr.size(); i++)
   {
     // get the field values

Original file line number	Diff line number	Diff line change
`@@ -506,7 +506,7 @@ void QgsAttributeTable::putFeatureInTable(int row, QgsFeature* fet)`
`506`	`506`	`int id = fet->featureId();`
`507`	`507`	`setText(row, 0, QString::number(id));`
`508`	`508`	`insertFeatureId(id, row); //insert the id into the search tree of qgsattributetable`
`509`		`- std::vector < QgsFeatureAttribute > attr = fet->attributeMap();`
	`509`	`+ const std::vector < QgsFeatureAttribute >& attr = fet->attributeMap();`
`510`	`510`	`for (int i = 0; i < attr.size(); i++)`
`511`	`511`	`{`
`512`	`512`	`// get the field values`