Skip to content

Commit

Permalink
Fixes after review
Browse files Browse the repository at this point in the history
  • Loading branch information
wonder-sk committed Dec 5, 2017
1 parent b773d61 commit 1f6cd31
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/3d/qgs3dutils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ QString Qgs3DUtils::cullingModeToString( Qt3DRender::QCullFace::CullingMode mode
case Qt3DRender::QCullFace::Front: return QStringLiteral( "front" );
case Qt3DRender::QCullFace::Back: return QStringLiteral( "back" );
case Qt3DRender::QCullFace::FrontAndBack: return QStringLiteral( "front-and-back" );
default: return QString();
}
return QString();
}

Qt3DRender::QCullFace::CullingMode Qgs3DUtils::cullingModeFromString( const QString &str )
Expand Down
2 changes: 1 addition & 1 deletion src/3d/qgstessellator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ void QgsTessellator::addPolygon( const QgsPolygon &polygon, float extrusionHeigh
polylinesToDelete << holePolyline;
}

// run triangulation and write vertices to the ouput data array
// run triangulation and write vertices to the output data array
try
{
cdt->Triangulate();
Expand Down
2 changes: 1 addition & 1 deletion src/3d/symbols/qgspolygon3dsymbol_p.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ Qt3DExtras::QPhongMaterial *QgsPolygon3DSymbolEntity::material( const QgsPolygon

// front/back side culling
auto techniques = material->effect()->techniques();
for ( auto tit = techniques.begin(); tit != techniques.end(); ++tit )
for ( auto tit = techniques.constBegin(); tit != techniques.constEnd(); ++tit )
{
auto renderPasses = ( *tit )->renderPasses();
for ( auto rpit = renderPasses.begin(); rpit != renderPasses.end(); ++rpit )
Expand Down

0 comments on commit 1f6cd31

Please sign in to comment.