Skip to content

Commit 2030245

Browse files
author
telwertowski
committed
Don't create Mac menubar if table is displayed inside dock.
git-svn-id: http://svn.osgeo.org/qgis/trunk/qgis@9256 c8812cc2-4d05-0410-92ff-de0c093fc19c
1 parent 710b581 commit 2030245

File tree

1 file changed

+47
-44
lines changed

1 file changed

+47
-44
lines changed

src/app/qgsattributetabledisplay.cpp

Lines changed: 47 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -132,55 +132,58 @@ QgsAttributeTableDisplay::QgsAttributeTableDisplay( QgsVectorLayer* layer )
132132
setWindowTitle( tr( "Attribute table - " ) + layer->name() );
133133

134134
#ifdef Q_WS_MAC
135-
QMenuBar *menuBar = new QMenuBar( this );
136-
137-
QMenu *appMenu = menuBar->addMenu( tr( "QGIS" ) );
138-
appMenu->addAction( QgisApp::instance()->actionAbout() );
139-
appMenu->addAction( QgisApp::instance()->actionOptions() );
140-
141-
QMenu *fileMenu = menuBar->addMenu( tr( "File" ) );
142-
QAction *closeAction = fileMenu->addAction( tr( "Close" ), this, SLOT( close() ), tr( "Ctrl+W" ) );
143-
144-
QMenu *editMenu = menuBar->addMenu( tr( "Edit" ) );
145-
QAction *undoAction = editMenu->addAction( tr( "&Undo" ), this, SLOT( undo() ), tr( "Ctrl+Z" ) );
146-
undoAction->setEnabled( false );
147-
editMenu->addSeparator();
148-
QAction *cutAction = editMenu->addAction( tr( "Cu&t" ), this, SLOT( cut() ), tr( "Ctrl+X" ) );
149-
cutAction->setEnabled( false );
150-
QAction *copyAction = editMenu->addAction(
151-
mCopySelectedRowsButton->icon(), tr( "&Copy" ), this, SLOT( copySelectedRowsToClipboard() ), tr( "Ctrl+C" ) );
152-
QAction *pasteAction = editMenu->addAction( tr( "&Paste" ), this, SLOT( paste() ), tr( "Ctrl+V" ) );
153-
pasteAction->setEnabled( false );
154-
QAction *deleteAction = editMenu->addAction(
155-
mRemoveSelectionButton->icon(), tr( "Delete" ), this, SLOT( removeSelection() ) );
156-
157-
QMenu *layerMenu = menuBar->addMenu( tr( "Layer" ) );
158-
QAction *zoomToSelectedAction = layerMenu->addAction(
159-
mZoomMapToSelectedRowsButton->icon(), tr( "Zoom to Selection" ), this, SLOT( zoomMapToSelectedRows() ), tr( "Ctrl+J" ) );
160-
layerMenu->addSeparator();
161-
QAction *toggleEditingAction = layerMenu->addAction(
162-
mToggleEditingButton->icon(), tr( "Toggle Editing" ), this, SLOT( toggleEditing() ) );
163-
toggleEditingAction->setEnabled( mToggleEditingButton->isEnabled() );
164-
toggleEditingAction->setCheckable( true );
165-
toggleEditingAction->setChecked( mToggleEditingButton->isChecked() );
166-
connect( mToggleEditingButton, SIGNAL( toggled( bool ) ), toggleEditingAction, SLOT( setChecked( bool ) ) );
167-
168-
QMenu *tableMenu = menuBar->addMenu( tr( "Table" ) );
169-
QAction *moveToTopAction = tableMenu->addAction(
170-
mSelectedToTopButton->icon(), tr( "Move to Top" ), this, SLOT( selectedToTop() ) );
171-
QAction *invertAction = tableMenu->addAction(
172-
mInvertSelectionButton->icon(), tr( "Invert" ), this, SLOT( invertSelection() ) );
135+
if ( !myDockFlag )
136+
{
137+
QMenuBar *menuBar = new QMenuBar( this );
138+
139+
QMenu *appMenu = menuBar->addMenu( tr( "QGIS" ) );
140+
appMenu->addAction( QgisApp::instance()->actionAbout() );
141+
appMenu->addAction( QgisApp::instance()->actionOptions() );
142+
143+
QMenu *fileMenu = menuBar->addMenu( tr( "File" ) );
144+
QAction *closeAction = fileMenu->addAction( tr( "Close" ), this, SLOT( close() ), tr( "Ctrl+W" ) );
145+
146+
QMenu *editMenu = menuBar->addMenu( tr( "Edit" ) );
147+
QAction *undoAction = editMenu->addAction( tr( "&Undo" ), this, SLOT( undo() ), tr( "Ctrl+Z" ) );
148+
undoAction->setEnabled( false );
149+
editMenu->addSeparator();
150+
QAction *cutAction = editMenu->addAction( tr( "Cu&t" ), this, SLOT( cut() ), tr( "Ctrl+X" ) );
151+
cutAction->setEnabled( false );
152+
QAction *copyAction = editMenu->addAction(
153+
mCopySelectedRowsButton->icon(), tr( "&Copy" ), this, SLOT( copySelectedRowsToClipboard() ), tr( "Ctrl+C" ) );
154+
QAction *pasteAction = editMenu->addAction( tr( "&Paste" ), this, SLOT( paste() ), tr( "Ctrl+V" ) );
155+
pasteAction->setEnabled( false );
156+
QAction *deleteAction = editMenu->addAction(
157+
mRemoveSelectionButton->icon(), tr( "Delete" ), this, SLOT( removeSelection() ) );
158+
159+
QMenu *layerMenu = menuBar->addMenu( tr( "Layer" ) );
160+
QAction *zoomToSelectedAction = layerMenu->addAction(
161+
mZoomMapToSelectedRowsButton->icon(), tr( "Zoom to Selection" ), this, SLOT( zoomMapToSelectedRows() ), tr( "Ctrl+J" ) );
162+
layerMenu->addSeparator();
163+
QAction *toggleEditingAction = layerMenu->addAction(
164+
mToggleEditingButton->icon(), tr( "Toggle Editing" ), this, SLOT( toggleEditing() ) );
165+
toggleEditingAction->setEnabled( mToggleEditingButton->isEnabled() );
166+
toggleEditingAction->setCheckable( true );
167+
toggleEditingAction->setChecked( mToggleEditingButton->isChecked() );
168+
connect( mToggleEditingButton, SIGNAL( toggled( bool ) ), toggleEditingAction, SLOT( setChecked( bool ) ) );
169+
170+
QMenu *tableMenu = menuBar->addMenu( tr( "Table" ) );
171+
QAction *moveToTopAction = tableMenu->addAction(
172+
mSelectedToTopButton->icon(), tr( "Move to Top" ), this, SLOT( selectedToTop() ) );
173+
QAction *invertAction = tableMenu->addAction(
174+
mInvertSelectionButton->icon(), tr( "Invert" ), this, SLOT( invertSelection() ) );
173175

174176
#ifndef Q_WS_MAC64 /* assertion failure in NSMenuItem setSubmenu (Qt 4.5.0-snapshot-20080830) */
175-
menuBar->addMenu( QgisApp::instance()->windowMenu() );
177+
menuBar->addMenu( QgisApp::instance()->windowMenu() );
176178

177-
menuBar->addMenu( QgisApp::instance()->helpMenu() );
179+
menuBar->addMenu( QgisApp::instance()->helpMenu() );
178180
#endif
179181

180-
// Create action to select this window and add it to Window menu
181-
mWindowAction = new QAction( windowTitle(), this );
182-
connect( mWindowAction, SIGNAL( triggered() ), this, SLOT( activate() ) );
183-
QgisApp::instance()->addWindow( mWindowAction );
182+
// Create action to select this window and add it to Window menu
183+
mWindowAction = new QAction( windowTitle(), this );
184+
connect( mWindowAction, SIGNAL( triggered() ), this, SLOT( activate() ) );
185+
QgisApp::instance()->addWindow( mWindowAction );
186+
}
184187
#endif
185188
}
186189

0 commit comments

Comments
 (0)