Skip to content

Commit 20c5e54

Browse files
committed
Fix some clazy warnings
1 parent d5d553f commit 20c5e54

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

src/core/layout/qgsabstractreportsection.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,14 +77,14 @@ bool QgsAbstractReportSection::writeXml( QDomElement &parentElement, QDomDocumen
7777
QDomElement element = doc.createElement( QStringLiteral( "Section" ) );
7878
element.setAttribute( QStringLiteral( "type" ), type() );
7979

80-
element.setAttribute( QStringLiteral( "headerEnabled" ), mHeaderEnabled ? "1" : "0" );
80+
element.setAttribute( QStringLiteral( "headerEnabled" ), mHeaderEnabled ? QStringLiteral( "1" ) : QStringLiteral( "0" ) );
8181
if ( mHeader )
8282
{
8383
QDomElement headerElement = doc.createElement( QStringLiteral( "header" ) );
8484
headerElement.appendChild( mHeader->writeXml( doc, context ) );
8585
element.appendChild( headerElement );
8686
}
87-
element.setAttribute( QStringLiteral( "footerEnabled" ), mFooterEnabled ? "1" : "0" );
87+
element.setAttribute( QStringLiteral( "footerEnabled" ), mFooterEnabled ? QStringLiteral( "1" ) : QStringLiteral( "0" ) );
8888
if ( mFooter )
8989
{
9090
QDomElement footerElement = doc.createElement( QStringLiteral( "footer" ) );
@@ -110,8 +110,8 @@ bool QgsAbstractReportSection::readXml( const QDomElement &element, const QDomDo
110110
return false;
111111
}
112112

113-
mHeaderEnabled = element.attribute( QStringLiteral( "headerEnabled" ), "0" ).toInt();
114-
mFooterEnabled = element.attribute( QStringLiteral( "footerEnabled" ), "0" ).toInt();
113+
mHeaderEnabled = element.attribute( QStringLiteral( "headerEnabled" ), QStringLiteral( "0" ) ).toInt();
114+
mFooterEnabled = element.attribute( QStringLiteral( "footerEnabled" ), QStringLiteral( "0" ) ).toInt();
115115
const QDomElement headerElement = element.firstChildElement( QStringLiteral( "header" ) );
116116
if ( !headerElement.isNull() )
117117
{

src/providers/arcgisrest/qgsafsshareddata.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ bool QgsAfsSharedData::getFeature( QgsFeatureId id, QgsFeature &f, const QgsRect
3939
QStringList fetchAttribNames;
4040
QList<int> fetchAttribIdx;
4141
fetchAttribIdx.reserve( mFields.size() );
42+
fetchAttribNames.reserve( mFields.size() );
4243
for ( int idx = 0, n = mFields.size(); idx < n; ++idx )
4344
{
4445
fetchAttribNames.append( mFields.at( idx ).name() );
@@ -58,7 +59,7 @@ bool QgsAfsSharedData::getFeature( QgsFeatureId id, QgsFeature &f, const QgsRect
5859

5960
if ( objectIds.empty() )
6061
{
61-
QgsDebugMsg( "No valid features IDs to fetch" );
62+
QgsDebugMsg( QStringLiteral( "No valid features IDs to fetch" ) );
6263
return false;
6364
}
6465

@@ -75,7 +76,7 @@ bool QgsAfsSharedData::getFeature( QgsFeatureId id, QgsFeature &f, const QgsRect
7576
if ( queryData.isEmpty() )
7677
{
7778
// const_cast<QgsAfsProvider *>( this )->pushError( errorTitle + ": " + errorMessage );
78-
QgsDebugMsg( "Query returned empty result" );
79+
QgsDebugMsg( QStringLiteral( "Query returned empty result" ) );
7980
return false;
8081
}
8182

@@ -84,7 +85,7 @@ bool QgsAfsSharedData::getFeature( QgsFeatureId id, QgsFeature &f, const QgsRect
8485
const QVariantList featuresData = queryData[QStringLiteral( "features" )].toList();
8586
if ( featuresData.isEmpty() )
8687
{
87-
QgsDebugMsgLevel( "Query returned no features", 3 );
88+
QgsDebugMsgLevel( QStringLiteral( "Query returned no features" ), 3 );
8889
return false;
8990
}
9091
for ( int i = 0, n = featuresData.size(); i < n; ++i )

0 commit comments

Comments
 (0)