-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix wrong mapping of feature ids in offline editing
Fix #14727
- Loading branch information
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
216623f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elpaso
Since you also work(ed) with offline editing, can you make sure that this still works for you? Just want to be sure that this didn't introduce other problems.
216623f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kuhn
It looks good to me. I tested it in postgis and it works well.
WFS-T is completely broken anyway (except for INSERT), working on that with @rouault
I wonder why the original implementation was iterating backward on remote features ids ...
216623f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
216623f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non persistent fids are probably the cause of #14196 too.
216623f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we are able to make these fids persistent (are we?).
QgsVectorDataProvider::pkAttributeIndexes()
to the feature id for reverse lookup when sync'ing back.216623f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested this with June 27 QGIS Weekly and works good with PostGIS layer.
216623f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback!
216623f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kuhn I've added a test for WFS offline editing #3258 can you please have a look?