Fix a crash on attribute form widget

elpaso · elpaso · commit 2609815cd134 · 2018-10-03T11:28:01.000+02:00
Fixes #19388 - Consistent crash with join layer
diff --git a/src/gui/qgsattributeform.cpp b/src/gui/qgsattributeform.cpp
@@ -1654,7 +1654,7 @@ QgsAttributeForm::WidgetInfo QgsAttributeForm::createWidgetFromDef( const QgsAtt
         addWidgetWrapper( eww );
 
         newWidgetInfo.widget->setObjectName( fields.at( fldIdx ).name() );
-        newWidgetInfo.hint = fields.at( fieldDef->idx() ).comment();
+        newWidgetInfo.hint = fields.at( fldIdx ).comment();
       }
 
       newWidgetInfo.labelOnTop = mLayer->editFormConfig().labelOnTop( fieldDef->idx() );

Original file line number	Diff line number	Diff line change
`@@ -1654,7 +1654,7 @@ QgsAttributeForm::WidgetInfo QgsAttributeForm::createWidgetFromDef( const QgsAtt`
`1654`	`1654`	`addWidgetWrapper( eww );`
`1655`	`1655`
`1656`	`1656`	`newWidgetInfo.widget->setObjectName( fields.at( fldIdx ).name() );`
`1657`		`- newWidgetInfo.hint = fields.at( fieldDef->idx() ).comment();`
	`1657`	`+ newWidgetInfo.hint = fields.at( fldIdx ).comment();`
`1658`	`1658`	`}`
`1659`	`1659`
`1660`	`1660`	`newWidgetInfo.labelOnTop = mLayer->editFormConfig().labelOnTop( fieldDef->idx() );`