Skip to content
Permalink
Browse files

fix QAction constr call

  • Loading branch information
3nids committed Jan 16, 2018
1 parent 9bf943a commit 279785302dfca7806939a39968586e7389543ccc
Showing with 2 additions and 2 deletions.
  1. +2 −2 src/gui/qgsfilterlineedit.cpp
@@ -35,13 +35,13 @@ QgsFilterLineEdit::QgsFilterLineEdit( QWidget *parent, const QString &nullValue
QIcon clearIcon;
clearIcon.addPixmap( QgsApplication::getThemeIcon( "/mIconClearText.svg" ).pixmap( QSize( iconSize, iconSize ) ), QIcon::Normal, QIcon::On );
clearIcon.addPixmap( QgsApplication::getThemeIcon( "/mIconClearTextHover.svg" ).pixmap( QSize( iconSize, iconSize ) ), QIcon::Selected, QIcon::On );
mClearAction = new QAction( clearIcon, this );
mClearAction = new QAction( clearIcon, QString(), this );
mClearAction->setCheckable( false );
addAction( mClearAction, QLineEdit::TrailingPosition );
connect( mClearAction, &QAction::triggered, this, &QgsFilterLineEdit::clearValue );

QIcon searchIcon = QgsApplication::getThemeIcon( "/search.svg" );
mSearchAction = new QAction( searchIcon, this );
mSearchAction = new QAction( searchIcon, QString(), this );
mSearchAction->setCheckable( false );
addAction( mSearchAction, QLineEdit::TrailingPosition );
mSearchAction->setVisible( false );

4 comments on commit 2797853

@alexbruy

This comment has been minimized.

Copy link
Contributor

@alexbruy alexbruy replied Jan 23, 2018

Not sure if this related but now actions overlaps and can not be triggered by mouse anymore.
glitch

@3nids

This comment has been minimized.

Copy link
Member Author

@3nids 3nids replied Jan 23, 2018

where does it happen?
I could not reproduce in Python

@alexbruy

This comment has been minimized.

Copy link
Contributor

@alexbruy alexbruy replied Jan 23, 2018

I see this with all QgsFilterLineEdit widgets in QGIS. For example inside Datasource Manager or filter in Processing toolbox. Probably, I picked wrong commit from #6070.

@3nids

This comment has been minimized.

Copy link
Member Author

@3nids 3nids replied Jan 24, 2018

still not able to reproduce the issue.
Which Qt version are you using?
Can you make a small screenshot gif to show how it ended up like this?

Please sign in to comment.
You can’t perform that action at this time.