Skip to content

Commit

Permalink
fix QAction constr call
Browse files Browse the repository at this point in the history
  • Loading branch information
@3nids
3nids committed Jan 16, 2018
1 parent 9bf943a commit 2797853
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/gui/qgsfilterlineedit.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ QgsFilterLineEdit::QgsFilterLineEdit( QWidget *parent, const QString &nullValue
QIcon clearIcon;
clearIcon.addPixmap( QgsApplication::getThemeIcon( "/mIconClearText.svg" ).pixmap( QSize( iconSize, iconSize ) ), QIcon::Normal, QIcon::On );
clearIcon.addPixmap( QgsApplication::getThemeIcon( "/mIconClearTextHover.svg" ).pixmap( QSize( iconSize, iconSize ) ), QIcon::Selected, QIcon::On );
mClearAction = new QAction( clearIcon, this );
mClearAction = new QAction( clearIcon, QString(), this );
mClearAction->setCheckable( false );
addAction( mClearAction, QLineEdit::TrailingPosition );
connect( mClearAction, &QAction::triggered, this, &QgsFilterLineEdit::clearValue );

QIcon searchIcon = QgsApplication::getThemeIcon( "/search.svg" );
mSearchAction = new QAction( searchIcon, this );
mSearchAction = new QAction( searchIcon, QString(), this );
mSearchAction->setCheckable( false );
addAction( mSearchAction, QLineEdit::TrailingPosition );
mSearchAction->setVisible( false );
Expand Down

4 comments on commit 2797853

@alexbruy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this related but now actions overlaps and can not be triggered by mouse anymore.
glitch

@3nids
Copy link
Member Author

@3nids 3nids commented on 2797853 Jan 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does it happen?
I could not reproduce in Python

@alexbruy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this with all QgsFilterLineEdit widgets in QGIS. For example inside Datasource Manager or filter in Processing toolbox. Probably, I picked wrong commit from #6070.

@3nids
Copy link
Member Author

@3nids 3nids commented on 2797853 Jan 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not able to reproduce the issue.
Which Qt version are you using?
Can you make a small screenshot gif to show how it ended up like this?

Please sign in to comment.