Merge pull request #7211 from elpaso/bugfix-19145-legend-crash

[bugfix] Do not crash when removing a layout legend item

Author: elpaso

src/core/layertree/qgslayertree.cpp

@@ -138,6 +138,10 @@ void QgsLayerTree::writeXml( QDomElement &parentElement, const QgsReadWriteConte
 
   Q_FOREACH ( QgsMapLayer *layer, mCustomLayerOrder )
   {
+    // Safety belt, see https://issues.qgis.org/issues/19145
+    // Crash when deleting an item from the layout legend
+    if ( ! layer )
+      continue;
     QDomElement layerElem = doc.createElement( QStringLiteral( "item" ) );
     layerElem.appendChild( doc.createTextNode( layer->id() ) );
     customOrderElem.appendChild( layerElem );