-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Catch exceptions in transform() expression function
- Loading branch information
1 parent
a1e62a8
commit 2a8333e
Showing
2 changed files
with
13 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -810,6 +810,7 @@ class TestQgsExpression: public QObject | |
QTest::newRow( "smooth null" ) << "smooth(NULL,5)" << false << QVariant(); | ||
QTest::newRow( "smooth point" ) << "geom_to_wkt(smooth(geom_from_wkt('POINT(1 2)'),10))" << false << QVariant( "Point (1 2)" ); | ||
QTest::newRow( "smooth line" ) << "geom_to_wkt(smooth(geometry:=geom_from_wkt('LineString(0 0, 5 0, 5 5)'),iterations:=1,offset:=0.2,min_length:=-1,max_angle:=180))" << false << QVariant( "LineString (0 0, 4 0, 5 1, 5 5)" ); | ||
QTest::newRow( "transform invalid" ) << "transform(make_point(0,0),'EPSG:4326','EPSG:28356')" << false << QVariant(); | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
nyalldawson
Author
Collaborator
|
||
|
||
// string functions | ||
QTest::newRow( "lower" ) << "lower('HeLLo')" << false << QVariant( "hello" ); | ||
|
Apparently this transformation succeeds on mac
Do you have an idea, what's going on there? Do we need to take different CRS'es to perform this test or is there something else broken and this transformation is really meant to fail and it's bad that it succeeds on mac?
This is the reason for the blacklisted testqgsgeometry on mac.