Fix relation manager mess when adding new relations

m-kuhn · m-kuhn · commit 2b033c1acb60 · 2016-10-18T12:04:07.000+02:00
The table showed wrong information because it didn't take sorting into account
and relied on stable row numbers.
diff --git a/src/app/qgsrelationmanagerdialog.cpp b/src/app/qgsrelationmanagerdialog.cpp
@@ -46,6 +46,7 @@ void QgsRelationManagerDialog::setLayers( const QList< QgsVectorLayer* >& layers
 
 void QgsRelationManagerDialog::addRelation( const QgsRelation &rel )
 {
+  mRelationsTable->setSortingEnabled( false );
   int row = mRelationsTable->rowCount();
   mRelationsTable->insertRow( row );
 
@@ -74,6 +75,7 @@ void QgsRelationManagerDialog::addRelation( const QgsRelation &rel )
   item = new QTableWidgetItem( rel.id() );
   item->setFlags( Qt::ItemIsEditable );
   mRelationsTable->setItem( row, 5, item );
+  mRelationsTable->setSortingEnabled( true );
 }
 
 void QgsRelationManagerDialog::on_mBtnAddRelation_clicked()

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,7 @@ void QgsRelationManagerDialog::setLayers( const QList< QgsVectorLayer* >& layers`
`46`	`46`
`47`	`47`	`void QgsRelationManagerDialog::addRelation( const QgsRelation &rel )`
`48`	`48`	`{`
	`49`	`+ mRelationsTable->setSortingEnabled( false );`
`49`	`50`	`int row = mRelationsTable->rowCount();`
`50`	`51`	`mRelationsTable->insertRow( row );`
`51`	`52`
`@@ -74,6 +75,7 @@ void QgsRelationManagerDialog::addRelation( const QgsRelation &rel )`
`74`	`75`	`item = new QTableWidgetItem( rel.id() );`
`75`	`76`	`item->setFlags( Qt::ItemIsEditable );`
`76`	`77`	`mRelationsTable->setItem( row, 5, item );`
	`78`	`+ mRelationsTable->setSortingEnabled( true );`
`77`	`79`	`}`
`78`	`80`
`79`	`81`	`void QgsRelationManagerDialog::on_mBtnAddRelation_clicked()`