Skip to content

Commit 2c2d675

Browse files
committed
temporary fix for #8575 (building app as DLL is more involved and requires a CORE/GUI/APP_EXPORT macro dance...)
1 parent 618b58b commit 2c2d675

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

src/app/CMakeLists.txt

+7-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
SET(QGIS_APP_SRCS
2-
main.cpp
32
qgisapp.cpp
43
qgisappinterface.cpp
54
qgisappstylesheet.cpp
@@ -452,13 +451,17 @@ ENDIF (POSTGRES_FOUND)
452451

453452
#############
454453
IF (ANDROID)
455-
ADD_LIBRARY(${QGIS_APP_NAME} SHARED ${QGIS_APP_SRCS} ${QGIS_APP_MOC_SRCS} ${QGIS_APP_HDRS} ${QGIS_APP_MOC_HDRS} ${IMAGE_RCC_SRCS} ${TEST_RCC_SRCS})
454+
ADD_LIBRARY(${QGIS_APP_NAME} SHARED main.cpp ${QGIS_APP_SRCS} ${QGIS_APP_MOC_SRCS} ${QGIS_APP_HDRS} ${QGIS_APP_MOC_HDRS} ${IMAGE_RCC_SRCS} ${TEST_RCC_SRCS})
456455
ELSE (ANDROID)
457-
ADD_EXECUTABLE(${QGIS_APP_NAME} MACOSX_BUNDLE WIN32 ${QGIS_APP_SRCS} ${QGIS_APP_MOC_SRCS} ${IMAGE_RCC_SRCS} ${TEST_RCC_SRCS})
456+
ADD_EXECUTABLE(${QGIS_APP_NAME} MACOSX_BUNDLE WIN32 main.cpp ${QGIS_APP_SRCS} ${QGIS_APP_MOC_SRCS} ${IMAGE_RCC_SRCS} ${TEST_RCC_SRCS})
458457
ENDIF (ANDROID)
459458

460459
# shared library used by tests - TODO: use it also for qgis executable?
461-
ADD_LIBRARY(qgis_app SHARED ${QGIS_APP_SRCS} ${QGIS_APP_MOC_SRCS} ${QGIS_APP_HDRS} ${QGIS_APP_MOC_HDRS} ${IMAGE_RCC_SRCS})
460+
ADD_LIBRARY(qgis_app STATIC ${QGIS_APP_SRCS} ${QGIS_APP_MOC_SRCS} ${QGIS_APP_HDRS} ${QGIS_APP_MOC_HDRS} ${IMAGE_RCC_SRCS})
461+
462+
if(MSVC AND CMAKE_SIZEOF_VOID_P EQUAL 8)
463+
SET_TARGET_PROPERTIES(qgis_app PROPERTIES STATIC_LIBRARY_FLAGS "/machine:x64")
464+
ENDIF(MSVC AND CMAKE_SIZEOF_VOID_P EQUAL 8)
462465

463466
TARGET_LINK_LIBRARIES(${QGIS_APP_NAME}
464467
${QWT_LIBRARY}

src/app/qgisapp.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -8864,12 +8864,14 @@ void QgisApp::keyPressEvent( QKeyEvent * e )
88648864
{
88658865
stopRendering();
88668866
}
8867+
#if 0
88678868
#if defined(Q_OS_WIN)&& defined(QGISDEBUG)
88688869
else if ( e->key() == Qt::Key_Backslash && e->modifiers() & Qt::ControlModifier )
88698870
{
88708871
extern LONG WINAPI qgisCrashDump( struct _EXCEPTION_POINTERS *ExceptionInfo );
88718872
qgisCrashDump( 0 );
88728873
}
8874+
#endif
88738875
#endif
88748876
else
88758877
{

tests/src/app/CMakeLists.txt

+4
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,10 @@ MACRO (ADD_QGIS_TEST testname testsrc)
7474
qgis_gui
7575
qgis_analysis
7676
qgis_app)
77+
IF(WIN32)
78+
ADD_DEFINITIONS(-DQWT_DLL)
79+
TARGET_LINK_LIBRARIES(qgis_${testname} DbgHelp)
80+
ENDIF(WIN32)
7781
ADD_TEST(qgis_${testname} ${CMAKE_CURRENT_BINARY_DIR}/../../../output/bin/qgis_${testname})
7882
#SET_TARGET_PROPERTIES(qgis_${testname} PROPERTIES
7983
# INSTALL_RPATH ${CMAKE_INSTALL_PREFIX}/${QGIS_LIB_DIR}

0 commit comments

Comments
 (0)