-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Split displayField into displayExpression and mapTipTemplate (#1973)
Previously there was the expressionField (a field name or an expression) mainly used for the feature list in the form view of the dual view. On the other hand there was the displayField which could contain either a simple field name or a complex HTML structure with embedded expressions. And to know what it was you could compare it's content with the field names, if a field name matched, you used it as a displayField (original purpose) and if not... well, you could deal with HTML if you had a use for it. The main problem is that there are two different usages for this kind of thing * plain text identifier (field or expression) * pretty, rich text feature info This commit cleans up with this. You want rich text and a lot of info: go for mapTipTemplate. You want a plain text string to identify features: go for the displayExpression.
- Loading branch information
Showing
14 changed files
with
365 additions
and
483 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
2cf9243
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmm, looking into the source of maptips because I have some troubles on Windows with it.
But: so if I want to use expressions, I use.. displayExpression... huh oh no: mapTipTemplate :-)
what about mapTipTemplate (or mapTipExpression) and maptipField (just because we can as long as there is not a QGIS3)...
2cf9243
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kuhn i just wonder if these changes should not be mentioned in doc (worth a ticket). Afaics, (at least) the GUI, hence the UX, has evolved
2cf9243
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rduivenvoorde
both support expressions:
@DelazJ, I also think they sure deserve docs
2cf9243
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. Done in qgis/QGIS-Documentation#1542
2cf9243
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phew, glad I wrote a comprehensive commit message there 😄
2cf9243
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep on writing comprehensive commit message (and a bit less developer/designer-oriented 😉 ). It's appreciable
2cf9243
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this commit in particular, the impact for developers was bigger than for the enduser.
But I'll think of your statement in the next commit message I write 👍
2cf9243
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, reason why I was in doubt about its documentation until I see the dialog in qt.