Only enable update selection in field calc when we have a selection

NathanW2 · NathanW2 · commit 2d55c6d65763 · 2014-05-06T22:38:05.000+10:00
diff --git a/src/app/qgsfieldcalculator.cpp b/src/app/qgsfieldcalculator.cpp
@@ -85,7 +85,9 @@ QgsFieldCalculator::QgsFieldCalculator( QgsVectorLayer* vl )
     mNewFieldGroupBox->setCheckable( false );
   }
 
-  mOnlyUpdateSelectedCheckBox->setChecked( vl->selectedFeaturesIds().size() > 0 );
+  bool hasselection = vl->selectedFeaturesIds().size() > 0;
+  mOnlyUpdateSelectedCheckBox->setChecked( hasselection );
+  mOnlyUpdateSelectedCheckBox->setEnabled( hasselection );
 }
 
 QgsFieldCalculator::~QgsFieldCalculator()

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,9 @@ QgsFieldCalculator::QgsFieldCalculator( QgsVectorLayer* vl )`
`85`	`85`	`mNewFieldGroupBox->setCheckable( false );`
`86`	`86`	`}`
`87`	`87`
`88`		`- mOnlyUpdateSelectedCheckBox->setChecked( vl->selectedFeaturesIds().size() > 0 );`
	`88`	`+ bool hasselection = vl->selectedFeaturesIds().size() > 0;`
	`89`	`+ mOnlyUpdateSelectedCheckBox->setChecked( hasselection );`
	`90`	`+ mOnlyUpdateSelectedCheckBox->setEnabled( hasselection );`
`89`	`91`	`}`
`90`	`92`
`91`	`93`	`QgsFieldCalculator::~QgsFieldCalculator()`