Skip to content
Permalink
Browse files

Fix build against recent sip/PyQt4:

qgsfiledownloader.sip:33:0:
src/gui/qgsfiledownloader.h:94:5: error: overriding non-deleted function 'virtual QgsFileDownloader::~QgsFileDownloader()'

RuntimeError: qgis._core cannot import type 'QList<QVariant>' from PyQt4.QtCore
(cherry picked from commit 85a0db2)

fixes #16071
  • Loading branch information
manisandro authored and jef-n committed Mar 4, 2017
1 parent b86db94 commit 2efb2a38f10a5f6c4f46266dbc86a302f2e5d373
Showing with 4 additions and 1 deletion.
  1. +1 −0 python/core/core.sip
  2. +3 −1 src/gui/qgsfiledownloader.h
@@ -3,6 +3,7 @@

%Feature QT5_SUPPORT

%Import QtCore/QtCoremod.sip
%Import QtXml/QtXmlmod.sip
%Import QtNetwork/QtNetworkmod.sip
%Import QtSql/QtSqlmod.sip
@@ -90,8 +90,10 @@ class GUI_EXPORT QgsFileDownloader : public QObject
void onSslErrors( QNetworkReply *reply, const QList<QSslError> &errors );
#endif

private:
protected:
~QgsFileDownloader();

private:
/**
* Abort current request and show an error if the instance has GUI
* notifications enabled.

1 comment on commit 2efb2a3

@Scimmia22

This comment has been minimized.

Copy link
Contributor

@Scimmia22 Scimmia22 commented on 2efb2a3 Mar 8, 2017

This does not fix "RuntimeError: qgis._core cannot import type 'QList' from PyQt4.QtCore", it still happens when running QGIS and disables python support.

Please sign in to comment.
You can’t perform that action at this time.