Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Fix build against recent sip/PyQt4: 
qgsfiledownloader.sip:33:0:
src/gui/qgsfiledownloader.h:94:5: error: overriding non-deleted function 'virtual QgsFileDownloader::~QgsFileDownloader()'

RuntimeError: qgis._core cannot import type 'QList<QVariant>' from PyQt4.QtCore
(cherry picked from commit 85a0db2)

fixes #16071
  • Loading branch information
@manisandro @jef-n
manisandro authored and jef-n committed Mar 4, 2017
1 parent b86db94 commit 2efb2a3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions python/core/core.sip
View file
Expand Up @@ -3,6 +3,7 @@

%Feature QT5_SUPPORT

%Import QtCore/QtCoremod.sip
%Import QtXml/QtXmlmod.sip
%Import QtNetwork/QtNetworkmod.sip
%Import QtSql/QtSqlmod.sip
Expand Down
4 changes: 3 additions & 1 deletion src/gui/qgsfiledownloader.h
View file
Expand Up @@ -90,8 +90,10 @@ class GUI_EXPORT QgsFileDownloader : public QObject
void onSslErrors( QNetworkReply *reply, const QList<QSslError> &errors );
#endif

private:
protected:
~QgsFileDownloader();

private:
/**
* Abort current request and show an error if the instance has GUI
* notifications enabled.
Expand Down

1 comment on commit 2efb2a3

@Scimmia22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not fix "RuntimeError: qgis._core cannot import type 'QList' from PyQt4.QtCore", it still happens when running QGIS and disables python support.

Please sign in to comment.