Skip to content

Commit

Permalink
[Geometry checker] If fixing an error produced changes, treat newly d…
Browse files Browse the repository at this point in the history
…etected errors which are the same as the error fixed as actual new errors
  • Loading branch information
manisandro committed Jul 14, 2016
1 parent 41ce527 commit 2f6be7a
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions src/plugins/geometry_checker/qgsgeometrychecker.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -155,14 +155,17 @@ bool QgsGeometryChecker::fixError( QgsGeometryCheckError* error, int method )
}
}

// Remove just-fixed error from newly-found errors (needed in case error was fixed with "no change")
Q_FOREACH ( QgsGeometryCheckError* recheckErr, recheckErrors )
// Remove just-fixed error from newly-found errors if no changes occurred (needed in case error was fixed with "no change")
if ( changes.isEmpty() )
{
if ( recheckErr->isEqual( error ) )
Q_FOREACH ( QgsGeometryCheckError* recheckErr, recheckErrors )
{
recheckErrors.removeAll( recheckErr );
delete recheckErr;
break;
if ( recheckErr->isEqual( error ) )
{
recheckErrors.removeAll( recheckErr );
delete recheckErr;
break;
}
}
}

Expand Down

0 comments on commit 2f6be7a

Please sign in to comment.