Skip to content

Commit

Permalink
Minor Coverity fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
nyalldawson committed Aug 1, 2015
1 parent 4774c87 commit 2fb6c10
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
3 changes: 0 additions & 3 deletions src/app/nodetool/qgsmaptoolnodetool.h
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,6 @@ class QgsMapToolNodeTool: public QgsMapToolEdit
/** Dock widget which allows to edit vertices */
QgsNodeEditor* mNodeEditor;

/** Feature id of another feature where user clicked */
QgsFeatureId mAnother;

/** Stored position of last press down action to count how much vertexes should be moved */
QPoint mPressCoordinates;

Expand Down
2 changes: 1 addition & 1 deletion src/core/geometry/qgsgeometry.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ void QgsGeometry::detach( bool cloneGeom )

if ( d->ref > 1 )
{
d->ref.deref();
( void )d->ref.deref();

This comment has been minimized.

Copy link
@m-kuhn

m-kuhn Aug 1, 2015

Member

What does that do?

This comment has been minimized.

Copy link
@nyalldawson

nyalldawson Aug 1, 2015

Author Collaborator

Coverity was complaining about an ignored return value - this effectively show that we are doing that intentionally.

QgsAbstractGeometryV2* cGeom = 0;

if ( d->geometry && cloneGeom )
Expand Down
2 changes: 1 addition & 1 deletion src/gui/qgsgeometryrubberband.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ void QgsGeometryRubberBand::paint( QPainter* painter )

void QgsGeometryRubberBand::drawVertex( QPainter* p, double x, double y )
{
qreal s = ( mIconSize - 1 ) / 2;
qreal s = ( mIconSize - 1 ) / 2.0;

switch ( mIconType )
{
Expand Down

0 comments on commit 2fb6c10

Please sign in to comment.