Minor Coverity fixes

qgis · Aug 1, 2015 · 2fb6c106317b68bf22ba9b92e4a0bd8294e776a3 · m-kuhn · Aug 1, 2015 · nyalldawson
1 parent 4774c87
commit 2fb6c106317b68bf22ba9b92e4a0bd8294e776a3
Unified Split

Showing with 2 additions and 5 deletions.

+0 −3 src/app/nodetool/qgsmaptoolnodetool.h

+1 −1 src/core/geometry/qgsgeometry.cpp

+1 −1 src/gui/qgsgeometryrubberband.cpp
diff --git a/src/app/nodetool/qgsmaptoolnodetool.h b/src/app/nodetool/qgsmaptoolnodetool.h
@@ -120,9 +120,6 @@ class QgsMapToolNodeTool: public QgsMapToolEdit
     /** Dock widget which allows to edit vertices */
     QgsNodeEditor* mNodeEditor;
 
-    /** Feature id of another feature where user clicked */
-    QgsFeatureId mAnother;
-
     /** Stored position of last press down action to count how much vertexes should be moved */
     QPoint mPressCoordinates;
 

diff --git a/src/core/geometry/qgsgeometry.cpp b/src/core/geometry/qgsgeometry.cpp
@@ -109,7 +109,7 @@ void QgsGeometry::detach( bool cloneGeom )
 
   if ( d->ref > 1 )
   {
-    d->ref.deref();
+    ( void )d->ref.deref();
     QgsAbstractGeometryV2* cGeom = 0;
 
     if ( d->geometry && cloneGeom )

diff --git a/src/gui/qgsgeometryrubberband.cpp b/src/gui/qgsgeometryrubberband.cpp
@@ -73,7 +73,7 @@ void QgsGeometryRubberBand::paint( QPainter* painter )
 
 void QgsGeometryRubberBand::drawVertex( QPainter* p, double x, double y )
 {
-  qreal s = ( mIconSize - 1 ) / 2;
+  qreal s = ( mIconSize - 1 ) / 2.0;
 
   switch ( mIconType )
   {