Skip to content
Permalink
Browse files

Minor Coverity fixes

  • Loading branch information
nyalldawson committed Aug 1, 2015
1 parent 4774c87 commit 2fb6c106317b68bf22ba9b92e4a0bd8294e776a3
@@ -120,9 +120,6 @@ class QgsMapToolNodeTool: public QgsMapToolEdit
/** Dock widget which allows to edit vertices */
QgsNodeEditor* mNodeEditor;

/** Feature id of another feature where user clicked */
QgsFeatureId mAnother;

/** Stored position of last press down action to count how much vertexes should be moved */
QPoint mPressCoordinates;

@@ -109,7 +109,7 @@ void QgsGeometry::detach( bool cloneGeom )

if ( d->ref > 1 )
{
d->ref.deref();
( void )d->ref.deref();

This comment has been minimized.

Copy link
@m-kuhn

m-kuhn Aug 1, 2015

Member

What does that do?

This comment has been minimized.

Copy link
@nyalldawson

nyalldawson Aug 1, 2015

Author Collaborator

Coverity was complaining about an ignored return value - this effectively show that we are doing that intentionally.

QgsAbstractGeometryV2* cGeom = 0;

if ( d->geometry && cloneGeom )
@@ -73,7 +73,7 @@ void QgsGeometryRubberBand::paint( QPainter* painter )

void QgsGeometryRubberBand::drawVertex( QPainter* p, double x, double y )
{
qreal s = ( mIconSize - 1 ) / 2;
qreal s = ( mIconSize - 1 ) / 2.0;

switch ( mIconType )
{

0 comments on commit 2fb6c10

Please sign in to comment.
You can’t perform that action at this time.