Use isEmpty() rather than size() to check for empty lists

nyalldawson · nyalldawson · commit 2fb8695dbed3 · 2016-10-24T10:36:24.000+10:00
diff --git a/src/gui/qgssqlcomposerdialog.cpp b/src/gui/qgssqlcomposerdialog.cpp
@@ -456,7 +456,7 @@ void QgsSQLComposerDialog::getFunctionList( const QList<Function>& list,
     listApi << f.name;
     QString entryText( f.name );
     entryText += "(";
-    if ( f.argumentList.size() )
+    if ( !f.argumentList.isEmpty() )
     {
       for ( int i = 0;i < f.argumentList.size();i++ )
       {
diff --git a/src/providers/wfs/qgswfsshareddata.cpp b/src/providers/wfs/qgswfsshareddata.cpp
@@ -1162,7 +1162,7 @@ QgsGmlStreamingParser* QgsWFSSharedData::createParser()
     axisOrientationLogic = QgsGmlStreamingParser::Ignore_EPSG;
   }
 
-  if ( mLayerPropertiesList.size() )
+  if ( !mLayerPropertiesList.isEmpty() )
   {
     QList< QgsGmlStreamingParser::LayerProperties > layerPropertiesList;
     Q_FOREACH ( QgsOgcUtils::LayerProperties layerProperties, mLayerPropertiesList )

Original file line number	Diff line number	Diff line change
`@@ -456,7 +456,7 @@ void QgsSQLComposerDialog::getFunctionList( const QList<Function>& list,`
`456`	`456`	`listApi << f.name;`
`457`	`457`	`QString entryText( f.name );`
`458`	`458`	`entryText += "(";`
`459`		`- if ( f.argumentList.size() )`
	`459`	`+ if ( !f.argumentList.isEmpty() )`
`460`	`460`	`{`
`461`	`461`	`for ( int i = 0;i < f.argumentList.size();i++ )`
`462`	`462`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1162,7 +1162,7 @@ QgsGmlStreamingParser* QgsWFSSharedData::createParser()`
`1162`	`1162`	`axisOrientationLogic = QgsGmlStreamingParser::Ignore_EPSG;`
`1163`	`1163`	`}`
`1164`	`1164`
`1165`		`- if ( mLayerPropertiesList.size() )`
	`1165`	`+ if ( !mLayerPropertiesList.isEmpty() )`
`1166`	`1166`	`{`
`1167`	`1167`	`QList< QgsGmlStreamingParser::LayerProperties > layerPropertiesList;`
`1168`	`1168`	`Q_FOREACH ( QgsOgcUtils::LayerProperties layerProperties, mLayerPropertiesList )`