Fix leak in virtual layers

nyalldawson · nyalldawson · commit 30749ef80c37 · 2018-03-11T20:20:50.000+11:00
diff --git a/src/providers/virtual/qgsvirtuallayerqueryparser.cpp b/src/providers/virtual/qgsvirtuallayerqueryparser.cpp
@@ -40,7 +40,12 @@ namespace QgsVirtualLayerQueryParser
     {
       char *errMsg = nullptr;
       int r = sqlite3_exec( db.get(), query.toUtf8().constData(), nullptr, nullptr, &errMsg );
-      QString err = QString::fromUtf8( errMsg );
+      QString err;
+      if ( r != SQLITE_OK )
+      {
+        err = QString::fromUtf8( errMsg );
+        sqlite3_free( errMsg );
+      }
       if ( r && err.startsWith( noSuchError ) )
       {
         QString tableName = err.mid( noSuchError.size() );

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,12 @@ namespace QgsVirtualLayerQueryParser`
`40`	`40`	`{`
`41`	`41`	`char *errMsg = nullptr;`
`42`	`42`	`int r = sqlite3_exec( db.get(), query.toUtf8().constData(), nullptr, nullptr, &errMsg );`
`43`		`- QString err = QString::fromUtf8( errMsg );`
	`43`	`+ QString err;`
	`44`	`+ if ( r != SQLITE_OK )`
	`45`	`+ {`
	`46`	`+ err = QString::fromUtf8( errMsg );`
	`47`	`+ sqlite3_free( errMsg );`
	`48`	`+ }`
`44`	`49`	`if ( r && err.startsWith( noSuchError ) )`
`45`	`50`	`{`
`46`	`51`	`QString tableName = err.mid( noSuchError.size() );`