Skip to content
Permalink
Browse files

Fixed timing/dangling pointer error in delimited text provider

  • Loading branch information
ccrook committed Mar 21, 2015
1 parent 60fcc4d commit 308bbb66bdf31345b893cb87aabe6fd9220148c2
Showing with 2 additions and 1 deletion.
  1. +2 −1 src/providers/delimitedtext/qgsdelimitedtextfeatureiterator.cpp
@@ -447,7 +447,7 @@ void QgsDelimitedTextFeatureIterator::fetchAttribute( QgsFeature& feature, int f

QgsDelimitedTextFeatureSource::QgsDelimitedTextFeatureSource( const QgsDelimitedTextProvider* p )
: mGeomRep( p->mGeomRep )
, mSubsetExpression( p->mSubsetExpression )
, mSubsetExpression( p->mSubsetExpression ? new QgsExpression(p->mSubsetExpression->expression()) : 0 )
, mExtent( p->mExtent )
, mUseSpatialIndex( p->mUseSpatialIndex )
, mSpatialIndex( p->mSpatialIndex ? new QgsSpatialIndex( *p->mSpatialIndex ) : 0 )
@@ -472,6 +472,7 @@ QgsDelimitedTextFeatureSource::QgsDelimitedTextFeatureSource( const QgsDelimited

QgsDelimitedTextFeatureSource::~QgsDelimitedTextFeatureSource()
{
delete mSubsetExpression;
delete mSpatialIndex;
delete mFile;
}

2 comments on commit 308bbb6

@nyalldawson

This comment has been minimized.

Copy link
Collaborator

@nyalldawson nyalldawson replied Mar 22, 2015

@ccrook should these provider fixes be backported to 2.8?

@ccrook

This comment has been minimized.

Copy link
Contributor Author

@ccrook ccrook replied Mar 22, 2015

@nyalldawson Yes .. good thought.

Please sign in to comment.
You can’t perform that action at this time.