Don't query list of visible features when showing selected features

nyalldawson · nyalldawson · commit 31c1be197359 · 2016-11-23T13:07:20.000+10:00
On behalf of Faunalia, sponsored by ENEL (cherry-picked from 5346023)
diff --git a/src/gui/attributetable/qgsattributetablefiltermodel.cpp b/src/gui/attributetable/qgsattributetablefiltermodel.cpp
@@ -292,11 +292,6 @@ void QgsAttributeTableFilterModel::setFilterMode( FilterMode filterMode )
       disconnect( mCanvas, SIGNAL( extentsChanged() ), this, SLOT( extentsChanged() ) );
     }
 
-    if ( filterMode == ShowSelected )
-    {
-      generateListOfVisibleFeatures();
-    }
-
     mFilterMode = filterMode;
     invalidateFilter();
   }
@@ -350,7 +345,6 @@ void QgsAttributeTableFilterModel::selectionChanged()
 {
   if ( ShowSelected == mFilterMode )
   {
-    generateListOfVisibleFeatures();
     invalidateFilter();
   }
   else if ( mSelectedOnTop )

Original file line number	Diff line number	Diff line change
`@@ -292,11 +292,6 @@ void QgsAttributeTableFilterModel::setFilterMode( FilterMode filterMode )`
`292`	`292`	`disconnect( mCanvas, SIGNAL( extentsChanged() ), this, SLOT( extentsChanged() ) );`
`293`	`293`	`}`
`294`	`294`
`295`		`- if ( filterMode == ShowSelected )`
`296`		`- {`
`297`		`- generateListOfVisibleFeatures();`
`298`		`- }`
`299`		`-`
`300`	`295`	`mFilterMode = filterMode;`
`301`	`296`	`invalidateFilter();`
`302`	`297`	`}`
`@@ -350,7 +345,6 @@ void QgsAttributeTableFilterModel::selectionChanged()`
`350`	`345`	`{`
`351`	`346`	`if ( ShowSelected == mFilterMode )`
`352`	`347`	`{`
`353`		`- generateListOfVisibleFeatures();`
`354`	`348`	`invalidateFilter();`
`355`	`349`	`}`
`356`	`350`	`else if ( mSelectedOnTop )`