Skip to content
Permalink
Browse files

[oracle] More code modernization

  • Loading branch information
nyalldawson committed Apr 22, 2018
1 parent 8d1b435 commit 31faa11bfb7d20b77c4af5436c54bea6c974a1b1
@@ -21,7 +21,7 @@ email : jef at norbit dot de

#include <QMetaType>

QgsOracleColumnTypeThread::QgsOracleColumnTypeThread( QString name, bool useEstimatedMetadata, bool allowGeometrylessTables )
QgsOracleColumnTypeThread::QgsOracleColumnTypeThread( const QString &name, bool useEstimatedMetadata, bool allowGeometrylessTables )
: QThread()
, mName( name )
, mUseEstimatedMetadata( useEstimatedMetadata )
@@ -70,9 +70,9 @@ void QgsOracleColumnTypeThread::run()
{
emit progress( i++, n );
emit progressMessage( tr( "Scanning column %1.%2.%3…" )
.arg( layerProperty.ownerName )
.arg( layerProperty.tableName )
.arg( layerProperty.geometryColName ) );
.arg( layerProperty.ownerName,
layerProperty.tableName,
layerProperty.geometryColName ) );
conn->retrieveLayerTypes( layerProperty, mUseEstimatedMetadata, QgsOracleConn::onlyExistingTypes( mName ) );
}

@@ -28,7 +28,7 @@ class QgsOracleColumnTypeThread : public QThread
{
Q_OBJECT
public:
QgsOracleColumnTypeThread( QString connName,
QgsOracleColumnTypeThread( const QString &connName,
bool useEstimatedMetaData,
bool allowGeometrylessTables );

@@ -51,12 +51,12 @@ class QgsOracleColumnTypeThread : public QThread
void stop();

private:
QgsOracleColumnTypeThread() {}
QgsOracleColumnTypeThread() = default;

QString mName;
bool mUseEstimatedMetadata;
bool mAllowGeometrylessTables;
bool mStopped;
bool mUseEstimatedMetadata = false;
bool mAllowGeometrylessTables = false;
bool mStopped = false;
QVector<QgsOracleLayerProperty> mLayerProperties;
};

0 comments on commit 31faa11

Please sign in to comment.
You can’t perform that action at this time.