[ui] resurrect home folder

Author: nirvn

images/themes/default/mIconFolderHome.svg

@@ -508,6 +508,13 @@ A Collection: logical collection of layers or subcollections, e.g. GRASS locatio
 %Docstring
 Shared open directory icon.
 
+.. versionadded:: 3.4
+%End
+
+    static QIcon homeDirIcon();
+%Docstring
+Shared home directory icon.
+
 .. versionadded:: 3.4
 %End
 };

python/core/auto_generated/qgsdataitem.sip.in

@@ -90,9 +90,6 @@ void QgsBrowserModel::addRootItems()
   // give the home directory a prominent third place
   QgsDirectoryItem *item = new QgsDirectoryItem( nullptr, tr( "Home" ), QDir::homePath(), QStringLiteral( HOME_PREFIX ) + QDir::homePath() );
   item->setSortKey( QStringLiteral( " 2" ) );
-  QStyle *style = QApplication::style();
-  QIcon homeIcon( style->standardIcon( QStyle::SP_DirHomeIcon ) );
-  item->setIcon( homeIcon );
   connectItem( item );
   mRootItems << item;
 

src/core/qgsbrowsermodel.cpp

@@ -94,6 +94,11 @@ QIcon QgsDataCollectionItem::openDirIcon()
   return QgsApplication::getThemeIcon( QStringLiteral( "/mIconFolderOpen.svg" ) );
 }
 
+QIcon QgsDataCollectionItem::homeDirIcon()
+{
+  return QgsApplication::getThemeIcon( QStringLiteral( "mIconFolderHome.svg" ) );
+}
+
 QIcon QgsDataCollectionItem::iconDir()
 {
   return QgsApplication::getThemeIcon( QStringLiteral( "/mIconFolder.svg" ) );
@@ -730,6 +735,9 @@ void QgsDirectoryItem::init()
 
 QIcon QgsDirectoryItem::icon()
 {
+  if ( mDirPath == QDir::homePath() )
+    return homeDirIcon();
+
   // still loading? show the spinner
   if ( state() == Populating )
     return QgsDataItem::icon();

src/core/qgsdataitem.cpp

@@ -530,6 +530,12 @@ class CORE_EXPORT QgsDataCollectionItem : public QgsDataItem
      * \since QGIS 3.4
      */
     static QIcon openDirIcon();
+
+    /**
+     * Shared home directory icon.
+     * \since QGIS 3.4
+     */
+    static QIcon homeDirIcon();
 };
 
 /**