Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Rename QgsNetworkLogger::removeRows() to removeRequestRows() to avoid…
… hiding base virtual method
  • Loading branch information
rouault authored and nyalldawson committed Jun 24, 2021
1 parent 8a6ed7d commit 3274780
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/app/devtools/networklogger/qgsnetworklogger.cpp
Expand Up @@ -190,7 +190,7 @@ QModelIndex QgsNetworkLogger::indexOfParentLayerTreeNode( QgsNetworkLoggerNode *
return createIndex( row, 0, parentNode );
}

void QgsNetworkLogger::removeRows( const QList<int> &rows )
void QgsNetworkLogger::removeRequestRows( const QList<int> &rows )
{
QList< int > res = rows;
std::sort( res.begin(), res.end(), std::greater< int >() );
Expand Down
5 changes: 1 addition & 4 deletions src/app/devtools/networklogger/qgsnetworklogger.h
Expand Up @@ -75,13 +75,10 @@ class QgsNetworkLogger : public QAbstractItemModel
*/
QList< QAction * > actions( const QModelIndex &index, QObject *parent );


using QAbstractItemModel::removeRows;

/**
* Removes a list of request \a rows from the log.
*/
void removeRows( const QList< int > &rows );
void removeRequestRows( const QList< int > &rows );

/**
* Returns the root node of the log.
Expand Down
Expand Up @@ -79,7 +79,7 @@ QgsNetworkLoggerTreeView::QgsNetworkLoggerTreeView( QgsNetworkLogger *logger, QW
break;
}

mLogger->removeRows( rowsToTrim );
mLogger->removeRequestRows( rowsToTrim );
}

if ( mAutoScroll )
Expand Down

0 comments on commit 3274780

Please sign in to comment.