Skip to content

Commit 32b7c53

Browse files
DelazJnyalldawson
authored andcommitted
Add icon to geometry combobox items
1 parent db07bc6 commit 32b7c53

4 files changed

+29
-26
lines changed

src/gui/ogr/qgsvectorlayersaveasdialog.cpp

+5-4
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,13 @@ void QgsVectorLayerSaveAsDialog::setup()
9898
mFormatComboBox->blockSignals( false );
9999

100100
//add geometry types to combobox
101+
QString path = QgsApplication::defaultThemePath();
101102
mGeometryTypeComboBox->addItem( tr( "Automatic" ), -1 );
102-
mGeometryTypeComboBox->addItem( QgsWkbTypes::displayString( QgsWkbTypes::Point ), QgsWkbTypes::Point );
103-
mGeometryTypeComboBox->addItem( QgsWkbTypes::displayString( QgsWkbTypes::LineString ), QgsWkbTypes::LineString );
104-
mGeometryTypeComboBox->addItem( QgsWkbTypes::displayString( QgsWkbTypes::Polygon ), QgsWkbTypes::Polygon );
103+
mGeometryTypeComboBox->addItem( QIcon( path + "/mIconPointLayer.svg" ), QgsWkbTypes::displayString( QgsWkbTypes::Point ), QgsWkbTypes::Point );
104+
mGeometryTypeComboBox->addItem( QIcon( path + "/mIconLineLayer.svg" ), QgsWkbTypes::displayString( QgsWkbTypes::LineString ), QgsWkbTypes::LineString );
105+
mGeometryTypeComboBox->addItem( QIcon( path + "/mIconPolygonLayer.svg" ), QgsWkbTypes::displayString( QgsWkbTypes::Polygon ), QgsWkbTypes::Polygon );
105106
mGeometryTypeComboBox->addItem( QgsWkbTypes::displayString( QgsWkbTypes::GeometryCollection ), QgsWkbTypes::GeometryCollection );
106-
mGeometryTypeComboBox->addItem( tr( "No geometry" ), QgsWkbTypes::NoGeometry );
107+
mGeometryTypeComboBox->addItem( QIcon( path + "/mActionOpenTable.svg" ), tr( "No geometry" ), QgsWkbTypes::NoGeometry );
107108
mGeometryTypeComboBox->setCurrentIndex( mGeometryTypeComboBox->findData( -1 ) );
108109

109110
mEncodingComboBox->addItems( QgsVectorDataProvider::availableEncodings() );

src/gui/qgsnewgeopackagelayerdialog.cpp

+13-12
Original file line numberDiff line numberDiff line change
@@ -64,22 +64,23 @@ QgsNewGeoPackageLayerDialog::QgsNewGeoPackageLayerDialog( QWidget *parent, Qt::W
6464
mAddAttributeButton->setIcon( QgsApplication::getThemeIcon( QStringLiteral( "/mActionNewAttribute.svg" ) ) );
6565
mRemoveAttributeButton->setIcon( QgsApplication::getThemeIcon( QStringLiteral( "/mActionDeleteAttribute.svg" ) ) );
6666

67-
mGeometryTypeBox->addItem( tr( "Non spatial" ), wkbNone );
68-
mGeometryTypeBox->addItem( tr( "Point" ), wkbPoint );
69-
mGeometryTypeBox->addItem( tr( "Line" ), wkbLineString );
70-
mGeometryTypeBox->addItem( tr( "Polygon" ), wkbPolygon );
71-
mGeometryTypeBox->addItem( tr( "MultiPoint" ), wkbMultiPoint );
72-
mGeometryTypeBox->addItem( tr( "MultiLine" ), wkbMultiLineString );
73-
mGeometryTypeBox->addItem( tr( "MultiPolygon" ), wkbMultiPolygon );
67+
QString path = QgsApplication::defaultThemePath();
68+
mGeometryTypeBox->addItem( QIcon( path + "/mActionOpenTable.svg" ), tr( "Non spatial" ), wkbNone );
69+
mGeometryTypeBox->addItem( QIcon( path + "/mIconPointLayer.svg" ), tr( "Point" ), wkbPoint );
70+
mGeometryTypeBox->addItem( QIcon( path + "/mIconLineLayer.svg" ), tr( "Line" ), wkbLineString );
71+
mGeometryTypeBox->addItem( QIcon( path + "/mIconPolygonLayer.svg" ), tr( "Polygon" ), wkbPolygon );
72+
mGeometryTypeBox->addItem( QIcon( path + "/mIconPointLayer.svg" ), tr( "MultiPoint" ), wkbMultiPoint );
73+
mGeometryTypeBox->addItem( QIcon( path + "/mIconLineLayer.svg" ), tr( "MultiLine" ), wkbMultiLineString );
74+
mGeometryTypeBox->addItem( QIcon( path + "/mIconPolygonLayer.svg" ), tr( "MultiPolygon" ), wkbMultiPolygon );
7475

7576
#if 0
7677
// QGIS always create CompoundCurve and there's no real interest of having just CircularString. CompoundCurve are more useful
77-
mGeometryTypeBox->addItem( tr( "CircularString" ), wkbCircularString );
78+
mGeometryTypeBox->addItem( QIcon( path + "/mIconLineLayer.svg" ), tr( "CircularString" ), wkbCircularString );
7879
#endif
79-
mGeometryTypeBox->addItem( tr( "CompoundCurve" ), wkbCompoundCurve );
80-
mGeometryTypeBox->addItem( tr( "CurvePolygon" ), wkbCurvePolygon );
81-
mGeometryTypeBox->addItem( tr( "MultiCurve" ), wkbMultiCurve );
82-
mGeometryTypeBox->addItem( tr( "MultiSurface" ), wkbMultiSurface );
80+
mGeometryTypeBox->addItem( QIcon( path + "/mIconLineLayer.svg" ), tr( "CompoundCurve" ), wkbCompoundCurve );
81+
mGeometryTypeBox->addItem( QIcon( path + "/mIconPolygonLayer.svg" ), tr( "CurvePolygon" ), wkbCurvePolygon );
82+
mGeometryTypeBox->addItem( QIcon( path + "/mIconLineLayer.svg" ), tr( "MultiCurve" ), wkbMultiCurve );
83+
mGeometryTypeBox->addItem( QIcon( path + "/mIconPolygonLayer.svg" ), tr( "MultiSurface" ), wkbMultiSurface );
8384

8485
mGeometryWithZCheckBox->setEnabled( false );
8586
mGeometryWithMCheckBox->setEnabled( false );

src/gui/qgsnewmemorylayerdialog.cpp

+8-7
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,14 @@ QgsNewMemoryLayerDialog::QgsNewMemoryLayerDialog( QWidget *parent, Qt::WindowFla
5454
QgsSettings settings;
5555
restoreGeometry( settings.value( QStringLiteral( "Windows/NewMemoryLayer/geometry" ) ).toByteArray() );
5656

57-
mGeometryTypeBox->addItem( tr( "Non spatial" ), QgsWkbTypes::NoGeometry );
58-
mGeometryTypeBox->addItem( tr( "Point" ), QgsWkbTypes::Point );
59-
mGeometryTypeBox->addItem( tr( "Line" ), QgsWkbTypes::LineString );
60-
mGeometryTypeBox->addItem( tr( "Polygon" ), QgsWkbTypes::Polygon );
61-
mGeometryTypeBox->addItem( tr( "MultiPoint" ), QgsWkbTypes::MultiPoint );
62-
mGeometryTypeBox->addItem( tr( "MultiLine" ), QgsWkbTypes::MultiLineString );
63-
mGeometryTypeBox->addItem( tr( "MultiPolygon" ), QgsWkbTypes::MultiPolygon );
57+
QString path = QgsApplication::defaultThemePath();
58+
mGeometryTypeBox->addItem( QIcon( path + "/mActionOpenTable.svg" ), tr( "Non spatial" ), QgsWkbTypes::NoGeometry );
59+
mGeometryTypeBox->addItem( QIcon( path + "/mIconPointLayer.svg" ), tr( "Point" ), QgsWkbTypes::Point );
60+
mGeometryTypeBox->addItem( QIcon( path + "/mIconLineLayer.svg" ), tr( "Line" ), QgsWkbTypes::LineString );
61+
mGeometryTypeBox->addItem( QIcon( path + "/mIconPolygonLayer.svg" ), tr( "Polygon" ), QgsWkbTypes::Polygon );
62+
mGeometryTypeBox->addItem( QIcon( path + "/mIconPointLayer.svg" ), tr( "MultiPoint" ), QgsWkbTypes::MultiPoint );
63+
mGeometryTypeBox->addItem( QIcon( path + "/mIconLineLayer.svg" ), tr( "MultiLine" ), QgsWkbTypes::MultiLineString );
64+
mGeometryTypeBox->addItem( QIcon( path + "/mIconPolygonLayer.svg" ), tr( "MultiPolygon" ), QgsWkbTypes::MultiPolygon );
6465

6566
mGeometryWithZCheckBox->setEnabled( false );
6667
mGeometryWithMCheckBox->setEnabled( false );

src/gui/qgsnewvectorlayerdialog.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,9 @@ QgsNewVectorLayerDialog::QgsNewVectorLayerDialog( QWidget *parent, Qt::WindowFla
5656
mWidth->setValidator( new QIntValidator( 1, 255, this ) );
5757
mPrecision->setValidator( new QIntValidator( 0, 15, this ) );
5858

59-
mGeometryTypeBox->addItem( tr( "Point" ), QgsWkbTypes::Point );
60-
mGeometryTypeBox->addItem( tr( "Line" ), QgsWkbTypes::LineString );
61-
mGeometryTypeBox->addItem( tr( "Polygon" ), QgsWkbTypes::Polygon );
59+
mGeometryTypeBox->addItem( QIcon( path + "/mIconPointLayer.svg" ), tr( "Point" ), QgsWkbTypes::Point );
60+
mGeometryTypeBox->addItem( QIcon( path + "/mIconLineLayer.svg" ), tr( "Line" ), QgsWkbTypes::LineString );
61+
mGeometryTypeBox->addItem( QIcon( path + "/mIconPolygonLayer.svg" ), tr( "Polygon" ), QgsWkbTypes::Polygon );
6262

6363
mOkButton = buttonBox->button( QDialogButtonBox::Ok );
6464
mOkButton->setEnabled( false );

0 commit comments

Comments
 (0)