[labels] Fix null data defined value was not ignored in some cases

Cherry-picked from eb6279a
qgis · Jul 8, 2015 · 3387392 · 3387392
1 parent 29a7bf7
commit 3387392
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/app/qgslabelpropertydialog.cpp b/src/app/qgslabelpropertydialog.cpp
@@ -219,7 +219,7 @@ void QgsLabelPropertyDialog::setDataDefinedValues( const QgsPalLayerSettings &la
     }
 
     QVariant result = layerSettings.dataDefinedValue( propIt.key(), mCurLabelFeat, vlayer->pendingFields() );
-    if ( !result.isValid() )
+    if ( !result.isValid() || result.isNull() )
     {
       //could not evaluate data defined value
       continue;

diff --git a/src/core/qgspallabeling.cpp b/src/core/qgspallabeling.cpp
@@ -1205,7 +1205,7 @@ bool QgsPalLayerSettings::dataDefinedEvaluate( DataDefinedProperties p, QVariant
 
   QVariant result = dataDefinedValue( p, *mCurFeat, *mCurFields );
 
-  if ( result.isValid() ) // filter NULL values? i.e. && !result.isNull()
+  if ( result.isValid() && !result.isNull() )
   {
     //QgsDebugMsgLevel( QString( "result type:" ) + QString( result.typeName() ), 4 );
     //QgsDebugMsgLevel( QString( "result string:" ) + result.toString(), 4 );