-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
6 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
338b4c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DelazJ you missed some
Catalogue
fixes. Can you run./scripts/spell_check/check_spelling.sh
to fix these?338b4c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@3nids I do not have a git infrastructure right now so I'm afraid it would only be in the evening.
Question: Isn't that run in the prepare-commit script (I set it to automatically run before each commit)?
338b4c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, but only on modified files (otherwise it would take too much time).
If you run the script directly (without argument), it runs on the whole source code.
338b4c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmmm... It makes sense.
So it will replace all occurrences except in the agignored files and #spellok lines, right?
I had checked the behavior of thoses tools but the files I found were written in a programmatic (hence mainly cryptic for me) language so I had to guess and wait for reviewers comments and improvements. Unless I miss it, worth mention in QGIS Dev Guide?
338b4c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct!
yep, adding a small paragraph could be added next to indentation