SIP_SKIP and tidy

qgis · May 4, 2023 · 34933d0 · 34933d0
1 parent fa5de44
commit 34933d0
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/python/gui/auto_generated/qgsadvanceddigitizingdockwidget.sip.in b/python/gui/auto_generated/qgsadvanceddigitizingdockwidget.sip.in
@@ -1049,12 +1049,6 @@ Emitted whenever the snapping to common angle option changes, angle = 0 means th
 .. versionadded:: 3.32
 %End
 
-    void commonAngleSnappingShowInFloaterChanged( bool enabled );
-%Docstring
-Emitted whenever the option to show common angle snapping in the floater changes.
-
-.. versionadded:: 3.32
-%End
 
   private:
     //! event filter for line edits in the dock UI (angle/distance/x/y line edits)

diff --git a/src/gui/qgsadvanceddigitizingdockwidget.cpp b/src/gui/qgsadvanceddigitizingdockwidget.cpp
@@ -124,7 +124,11 @@ QgsAdvancedDigitizingDockWidget::QgsAdvancedDigitizingDockWidget( QgsMapCanvas *
   mCommonAngleActionsMenu->addAction( showCommonAngleSnappingInFloaterAction );
 
   // common angles
-  QActionGroup *angleButtonGroup = new QActionGroup( mCommonAngleActionsMenu ); // actions are exclusive for common angles
+
+  // Suppress warning: Potential leak of memory pointed to by 'angleButtonGroup' [clang-analyzer-cplusplus.NewDeleteLeaks]
+#ifndef __clang_analyzer__
+  QActionGroup *angleButtonGroup = new QActionGroup( mCommonAngleActionsMenu ); // actions are exclusive for common angles NOLINT
+#endif
   mCommonAngleActions = QMap<QAction *, double>();
   QList< QPair< double, QString > > commonAngles;
   const QList<double> anglesDouble( { 0.0, 0.1, 0.5, 1.0, 5.0, 10.0, 15.0, 18.0, 22.5, 30.0, 45.0, 90.0} );
@@ -138,7 +142,10 @@ QgsAdvancedDigitizingDockWidget::QgsAdvancedDigitizingDockWidget( QgsMapCanvas *
     action->setCheckable( true );
     action->setChecked( it->first == mCommonAngleConstraint );
     mCommonAngleActionsMenu->addAction( action );
+    // Suppress warning: Potential leak of memory pointed to by 'angleButtonGroup' [clang-analyzer-cplusplus.NewDeleteLeaks]
+#ifndef __clang_analyzer__
     angleButtonGroup->addAction( action );
+#endif
     mCommonAngleActions.insert( action, it->first );
   }
 

diff --git a/src/gui/qgsadvanceddigitizingdockwidget.h b/src/gui/qgsadvanceddigitizingdockwidget.h
@@ -881,8 +881,9 @@ class GUI_EXPORT QgsAdvancedDigitizingDockWidget : public QgsDockWidget, private
     /**
      * Emitted whenever the option to show common angle snapping in the floater changes.
      * \since QGIS 3.32
+     * \note Not available in Python bindings
      */
-    void commonAngleSnappingShowInFloaterChanged( bool enabled );
+    void commonAngleSnappingShowInFloaterChanged( bool enabled ) SIP_SKIP;
 
   private slots:
     //! Sets the between line constraint by clicking on the perpendicular/parallel buttons