Fixes segmentation fault when dividing by zero

qgis · May 17, 2018 · 352dbcb8367e73d6ab9f28aa815ff378bbb1db14 · 352dbcb
1 parent d5cec14
commit 352dbcb8367e73d6ab9f28aa815ff378bbb1db14
Showing with 5 additions and 1 deletion.

+5 −1 src/gui/editorwidgets/qgsvaluerelationwidgetwrapper.cpp
diff --git a/src/gui/editorwidgets/qgsvaluerelationwidgetwrapper.cpp b/src/gui/editorwidgets/qgsvaluerelationwidgetwrapper.cpp
@@ -259,7 +259,11 @@ void QgsValueRelationWidgetWrapper::populate( )
   else if ( mTableWidget )
   {
     if ( mCache.size() > 0 )
-      mTableWidget->setRowCount( ( mCache.size() + config( QStringLiteral( "NofColumns" ) ).toInt() - 1 ) / config( QStringLiteral( "NofColumns" ) ).toInt() );
+    {
+      const int nofCols = config( QStringLiteral( "NofColumns" ) ).toInt();
+      const int denom = nofCols != 0 ? nofCols : 1;
+      mTableWidget->setRowCount( ( mCache.size() + nofCols - 1 ) / denom );
+    }
     else
       mTableWidget->setRowCount( 1 );
     if ( config( QStringLiteral( "NofColumns" ) ).toInt() > 0 )