Skip to content

Commit

Permalink
[oauth2] Remove call to override cursor during token refresh
Browse files Browse the repository at this point in the history
Unsafe to work with main GUI thread from background auth threads.
  • Loading branch information
dakcarto committed Jun 7, 2019
1 parent 14b27d5 commit 36080a2
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/auth/oauth2/qgsauthoauth2method.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#include "qgso2.h"
#include "qgsauthoauth2config.h"
#include "qgsauthoauth2edit.h"
#include "qgsguiutils.h"
#include "qgsnetworkaccessmanager.h"
#include "qgslogger.h"
#include "qgsmessagelog.h"
Expand Down Expand Up @@ -169,8 +168,6 @@ bool QgsAuthOAuth2Method::updateNetworkRequest( QNetworkRequest &request, const
connect( &r_timer, &QTimer::timeout, &rloop, &QEventLoop::quit );
r_timer.start();

QgsTemporaryCursorOverride waitCursor( Qt::WaitCursor );

// Asynchronously attempt the refresh
// TODO: This already has a timed reply setup in O2 base class (and in QgsNetworkAccessManager!)
// May need to address this or app crashes will occur!
Expand All @@ -183,8 +180,6 @@ bool QgsAuthOAuth2Method::updateNetworkRequest( QNetworkRequest &request, const
r_timer.stop();
}

waitCursor.release();

// refresh result should set o2 to (un)linked
}
}
Expand Down

0 comments on commit 36080a2

Please sign in to comment.