Skip to content

Commit 3676a38

Browse files
committed
Update QgsMapToolShowHideLabels to work with new vector api
- Works now, but should have worked before this fix
1 parent c90870d commit 3676a38

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

src/app/qgsmaptoolshowhidelabels.cpp

+4-6
Original file line numberDiff line numberDiff line change
@@ -210,16 +210,14 @@ bool QgsMapToolShowHideLabels::selectedFeatures( QgsVectorLayer* vlayer,
210210
QgsDebugMsg( "Selection layer: " + vlayer->name() );
211211
QgsDebugMsg( "Selection polygon: " + selectGeomTrans.exportToWkt() );
212212

213-
QgsFeatureIterator fit = vlayer->getFeatures( QgsFeatureRequest().setFilterRect( selectGeomTrans.boundingBox() ).setFlags( QgsFeatureRequest::NoGeometry | QgsFeatureRequest::ExactIntersect ).setSubsetOfAttributes( QgsAttributeList() ) );
213+
QgsFeatureIterator fit = vlayer->getFeatures( QgsFeatureRequest()
214+
.setFilterRect( selectGeomTrans.boundingBox() )
215+
.setFlags( QgsFeatureRequest::ExactIntersect )
216+
.setSubsetOfAttributes( QgsAttributeList() ) );
214217

215218
QgsFeature f;
216219
while ( fit.nextFeature( f ) )
217220
{
218-
QgsGeometry* g = f.geometry();
219-
220-
if ( !selectGeomTrans.intersects( g ) )
221-
continue;
222-
223221
selectedFeatIds.insert( f.id() );
224222
}
225223

0 commit comments

Comments
 (0)