fix from mloskot for vc++8 crashes

git-svn-id: http://svn.osgeo.org/qgis/trunk@5017 c8812cc2-4d05-0410-92ff-de0c093fc19c

Author: mhugent

src/providers/ogr/qgsogrprovider.cpp

@@ -620,7 +620,7 @@ void QgsOgrProvider::select(QgsRect *rect, bool useIntersect)
   // spatial query to select features
   std::cerr << "Selection rectangle is " << *rect << std::endl;
   OGRGeometry *filter = 0;
-  filter = new OGRPolygon();
+  filter = OGRGeometryFactory::createGeometry(wkbPolygon);
   QString wktExtent = QString("POLYGON ((%1))").arg(rect->asPolygon());
   const char *wktText = (const char *)wktExtent;
 
@@ -651,9 +651,7 @@ void QgsOgrProvider::select(QgsRect *rect, bool useIntersect)
     assert(result==OGRERR_NONE);
 #endif
   }
-  
-  delete filter;
-  
+  OGRGeometryFactory::destroyGeometry(filter);  
 } // QgsOgrProvider::select