Skip to content
Permalink
Browse files

Updates from review

  • Loading branch information
wonder-sk committed May 7, 2018
1 parent 875da3f commit 37241386880ee6e9c768ed0e4ac1903a8e664b04
Showing with 13 additions and 6 deletions.
  1. +9 −2 src/3d/qgstessellatedpolygongeometry.h
  2. +4 −4 src/3d/qgstessellator.h
@@ -46,9 +46,16 @@ class QgsTessellatedPolygonGeometry : public Qt3DRender::QGeometry
//! Sets whether the normals of triangles will be inverted (useful for fixing clockwise / counter-clockwise face vertex orders)
void setInvertNormals( bool invert ) { mInvertNormals = invert; }

//! Returns whether also triangles facing the other side will be created. Useful if input data have inconsistent order of vertices
/**
* Returns whether also triangles facing the other side will be created. Useful if input data have inconsistent order of vertices
* \since QGIS 3.2
*/
bool addBackFaces() const { return mAddBackFaces; }
//! Sets whether also triangles facing the other side will be created. Useful if input data have inconsistent order of vertices

/**
* Sets whether also triangles facing the other side will be created. Useful if input data have inconsistent order of vertices
* \since QGIS 3.2
*/
void setAddBackFaces( bool add ) { mAddBackFaces = add; }

//! Initializes vertex buffer from given polygons. Takes ownership of passed polygon geometries
@@ -55,10 +55,10 @@ class _3D_EXPORT QgsTessellator
std::unique_ptr< QgsMultiPolygon > asMultiPolygon() const;

private:
double mOriginX, mOriginY;
bool mAddNormals;
bool mInvertNormals;
bool mAddBackFaces;
double mOriginX = 0, mOriginY = 0;
bool mAddNormals = false;
bool mInvertNormals = false;
bool mAddBackFaces = false;
QVector<float> mData;
int mStride;
};

0 comments on commit 3724138

Please sign in to comment.
You can’t perform that action at this time.