Skip to content

Commit 391cb73

Browse files
committed
rebuild statistics drop-down menu only when field type changed
1 parent 68872e5 commit 391cb73

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

src/app/qgsstatisticalsummarydockwidget.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ QgsStatisticalSummaryDockWidget::QgsStatisticalSummaryDockWidget( QWidget *paren
9797
mOptionsToolButton->setMenu( mStatisticsMenu );
9898

9999
mFieldType = DataType::Numeric;
100+
mPreviousFieldType = DataType::Numeric;
100101
refreshStatisticsMenu();
101102
}
102103

@@ -120,7 +121,11 @@ void QgsStatisticalSummaryDockWidget::refreshStatistics()
120121
mFieldType = fieldType( mFieldExpressionWidget->currentField() );
121122
}
122123

123-
refreshStatisticsMenu();
124+
if ( mFieldType != mPreviousFieldType )
125+
{
126+
refreshStatisticsMenu();
127+
mPreviousFieldType = mFieldType;
128+
}
124129

125130
bool selectedOnly = mSelectedOnlyCheckBox->isChecked();
126131

src/app/qgsstatisticalsummarydockwidget.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ class APP_EXPORT QgsStatisticalSummaryDockWidget : public QgsDockWidget, private
8989

9090
QMenu *mStatisticsMenu = nullptr;
9191
DataType mFieldType;
92+
DataType mPreviousFieldType;
9293
};
9394

9495
#endif // QGSSTATISTICALSUMMARYDOCKWIDGET_H

0 commit comments

Comments
 (0)