Fix invalid color could be returned by QgsRandomColorsV2

nyalldawson · nyalldawson · commit 3c45b2352a2a · 2015-08-05T14:46:38.000+10:00
diff --git a/src/core/symbology-ng/qgsvectorcolorrampv2.cpp b/src/core/symbology-ng/qgsvectorcolorrampv2.cpp
@@ -397,7 +397,7 @@ QColor QgsRandomColorsV2::color( double value ) const
   }
 
   //can't use precalculated hues, use a totally random hue
-  int h = 1 + ( int )( 360.0 * qrand() / ( RAND_MAX + 1.0 ) );
+  int h = ( int )( 360.0 * qrand() / ( RAND_MAX + 1.0 ) );
   int s = ( qrand() % ( DEFAULT_RANDOM_SAT_MAX - DEFAULT_RANDOM_SAT_MIN + 1 ) ) + DEFAULT_RANDOM_SAT_MIN;
   int v = ( qrand() % ( maxVal - minVal + 1 ) ) + minVal;
   return QColor::fromHsv( h, s, v );

Original file line number	Diff line number	Diff line change
`@@ -397,7 +397,7 @@ QColor QgsRandomColorsV2::color( double value ) const`
`397`	`397`	`}`
`398`	`398`
`399`	`399`	`//can't use precalculated hues, use a totally random hue`
`400`		`- int h = 1 + ( int )( 360.0 * qrand() / ( RAND_MAX + 1.0 ) );`
	`400`	`+ int h = ( int )( 360.0 * qrand() / ( RAND_MAX + 1.0 ) );`
`401`	`401`	`int s = ( qrand() % ( DEFAULT_RANDOM_SAT_MAX - DEFAULT_RANDOM_SAT_MIN + 1 ) ) + DEFAULT_RANDOM_SAT_MIN;`
`402`	`402`	`int v = ( qrand() % ( maxVal - minVal + 1 ) ) + minVal;`
`403`	`403`	`return QColor::fromHsv( h, s, v );`