Skip some work if no data-defined properties are applied

8% speedup with 1m polygons in memory layer
qgis · Oct 3, 2014 · 3ce7be5 · 3ce7be5
1 parent d8ce7da
commit 3ce7be5
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/core/symbology-ng/qgsfillsymbollayerv2.cpp b/src/core/symbology-ng/qgsfillsymbollayerv2.cpp
@@ -77,6 +77,9 @@ QgsMapUnitScale QgsSimpleFillSymbolLayerV2::mapUnitScale() const
 
 void QgsSimpleFillSymbolLayerV2::applyDataDefinedSymbology( QgsSymbolV2RenderContext& context, QBrush& brush, QPen& pen, QPen& selPen )
 {
+  if ( mDataDefinedProperties.isEmpty() )
+    return; // shortcut
+
   QgsExpression* colorExpression = expression( "color" );
   if ( colorExpression )
   {