[fix #19870] correctly convert index to style category

3nids · 3nids · commit 3e8e6ba9cd15 · 2018-09-17T07:44:22.000-08:00
the shift is already done in the list, so no need to hack
diff --git a/src/app/qgsmaplayerstylecategoriesmodel.cpp b/src/app/qgsmaplayerstylecategoriesmodel.cpp
@@ -47,7 +47,7 @@ void QgsMapLayerStyleCategoriesModel::setShowAllCategories( bool showAll )
 
 QgsMapLayer::StyleCategory QgsMapLayerStyleCategoriesModel::index2category( const QModelIndex &index ) const
 {
-  return mCategoryList.at( index.row() - ( mShowAllCategories ? 1 : 0 ) );
+  return mCategoryList.at( index.row() );
 }
 
 int QgsMapLayerStyleCategoriesModel::rowCount( const QModelIndex & ) const

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ void QgsMapLayerStyleCategoriesModel::setShowAllCategories( bool showAll )`
`47`	`47`
`48`	`48`	`QgsMapLayer::StyleCategory QgsMapLayerStyleCategoriesModel::index2category( const QModelIndex &index ) const`
`49`	`49`	`{`
`50`		`- return mCategoryList.at( index.row() - ( mShowAllCategories ? 1 : 0 ) );`
	`50`	`+ return mCategoryList.at( index.row() );`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`int QgsMapLayerStyleCategoriesModel::rowCount( const QModelIndex & ) const`