fix #5905

Author: jef-n

src/app/qgsattributetabledialog.cpp

@@ -680,33 +680,10 @@ void QgsAttributeTableDialog::editingToggled()
   mRemoveAttribute->setEnabled( canDeleteAttributes && mLayer->isEditable() );
   mAddFeature->setEnabled( canAddFeatures && mLayer->isEditable() && mLayer->geometryType() == QGis::NoGeometry );
 
-  // (probably reload data if user stopped editing - possible revert)
-  mModel->reload( mModel->index( 0, 0 ), mModel->index( mModel->rowCount() - 1, mModel->columnCount() - 1 ) );
-
   // not necessary to set table read only if layer is not editable
   // because model always reflects actual state when returning item flags
 }
 
-// not used now
-void QgsAttributeTableDialog::startEditing()
-{
-  mLayer->startEditing();
-}
-
-// not used now
-void QgsAttributeTableDialog::submit()
-{
-  mLayer->commitChanges();
-}
-
-// not used now
-void QgsAttributeTableDialog::revert()
-{
-  mLayer->rollBack();
-  mModel->revert();
-  mModel->reload( mModel->index( 0, 0 ), mModel->index( mModel->rowCount() - 1, mModel->columnCount() - 1 ) );
-}
-
 void QgsAttributeTableDialog::on_mAddAttribute_clicked()
 {
   if ( !mLayer )

src/app/qgsattributetabledialog.h

@@ -66,14 +66,6 @@ class QgsAttributeTableDialog : public QDialog, private Ui::QgsAttributeTableDia
     void finished();
 
   private slots:
-    /**
-     * submits the data
-     */
-    void submit();
-    /**
-     * Reverts the changes
-     */
-    void revert();
     /**
      * Launches search
      */
@@ -148,10 +140,7 @@ class QgsAttributeTableDialog : public QDialog, private Ui::QgsAttributeTableDia
      * Shows advanced actions
      */
     void showAdvanced();
-    /**
-     * Starts editing mode
-     */
-    void startEditing();
+
     /**Opens dialog to add new attribute*/
     void on_mAddAttribute_clicked();
     /**Opens dialog to remove attribute*/

src/gui/attributetable/qgsattributetablemodel.cpp

@@ -388,7 +388,7 @@ QVariant QgsAttributeTableModel::headerData( int section, Qt::Orientation orient
     {
       return QVariant( section );
     }
-    else if ( section < mFieldCount )
+    else if ( section >= 0 && section < mFieldCount )
     {
       QString attributeName = mLayer->attributeAlias( mAttributes[section] );
       if ( attributeName.isEmpty() )