Fix for crash scenario: If the first thing you do in qgis is open grass layer, edit it using grass edit tools then return to work with a non grass layer and touch the canvas qgis crashes because mNonEditMapTool is not initialised.

timlinux · timlinux · commit 40f9ccabf9d5 · 2008-07-11T21:37:14.000Z
git-svn-id: http://svn.osgeo.org/qgis/trunk/qgis@8757 c8812cc2-4d05-0410-92ff-de0c093fc19c
diff --git a/src/app/qgisapp.cpp b/src/app/qgisapp.cpp
@@ -1419,6 +1419,8 @@ void QgisApp::createCanvas()
   mMapTools.mAddRing = new QgsMapToolAddRing(mMapCanvas);
   mMapTools.mAddRing->setAction(mActionAddRing);
   mMapTools.mAddIsland = new QgsMapToolAddIsland(mMapCanvas);
+  //ensure that non edit tool is initialised or we will get crashes in some situations
+  mNonEditMapTool = mMapTools.mPan; 
 }
 
 void QgisApp::createOverview()

Original file line number	Diff line number	Diff line change
`@@ -1419,6 +1419,8 @@ void QgisApp::createCanvas()`
`1419`	`1419`	`mMapTools.mAddRing = new QgsMapToolAddRing(mMapCanvas);`
`1420`	`1420`	`mMapTools.mAddRing->setAction(mActionAddRing);`
`1421`	`1421`	`mMapTools.mAddIsland = new QgsMapToolAddIsland(mMapCanvas);`
	`1422`	`+ //ensure that non edit tool is initialised or we will get crashes in some situations`
	`1423`	`+ mNonEditMapTool = mMapTools.mPan;`
`1422`	`1424`	`}`
`1423`	`1425`
`1424`	`1426`	`void QgisApp::createOverview()`