Disable Add Preset menu if current style is already a preset

Prevents duplicate entries which have unexpected behaviour
qgis · Aug 20, 2015 · 415aa83 · 415aa83
1 parent d2282a7
commit 415aa83
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/app/qgsvisibilitypresets.cpp b/src/app/qgsvisibilitypresets.cpp
@@ -44,7 +44,7 @@ QgsVisibilityPresets::QgsVisibilityPresets()
   mMenu->addAction( QgisApp::instance()->actionHideSelectedLayers() );
   mMenu->addSeparator();
 
-  mMenu->addAction( tr( "Add Preset..." ), this, SLOT( addPreset() ) );
+  mActionAddPreset = mMenu->addAction( tr( "Add Preset..." ), this, SLOT( addPreset() ) );
   mMenuSeparator = mMenu->addSeparator();
 
   mActionRemoveCurrentPreset = mMenu->addAction( tr( "Remove Current Preset" ), this, SLOT( removeCurrentPreset() ) );
@@ -263,5 +263,6 @@ void QgsVisibilityPresets::menuAboutToShow()
   }
   mMenu->insertActions( mMenuSeparator, mMenuPresetActions );
 
+  mActionAddPreset->setEnabled( !hasCurrent );
   mActionRemoveCurrentPreset->setEnabled( hasCurrent );
 }
diff --git a/src/app/qgsvisibilitypresets.h b/src/app/qgsvisibilitypresets.h
@@ -87,6 +87,7 @@ class APP_EXPORT QgsVisibilityPresets : public QObject
 
     QMenu* mMenu;
     QAction* mMenuSeparator;
+    QAction* mActionAddPreset;
     QAction* mActionRemoveCurrentPreset;
     QList<QAction*> mMenuPresetActions;
 };