Use bold font in tests + fix a unit test

Author: wonder-sk

tests/src/core/testqgsdatadefinedsizelegend.cpp

@@ -97,7 +97,7 @@ void TestQgsDataDefinedSizeLegend::testBasic()
 {
   QgsDataDefinedSizeLegend settings;
   settings.setLegendType( QgsDataDefinedSizeLegend::LegendCollapsed );
-  settings.setFont( QgsFontUtils::getStandardTestFont( QStringLiteral( "Roman" ) ) );
+  settings.setFont( QgsFontUtils::getStandardTestFont( QStringLiteral( "Bold" ) ) );
 
   QList<QgsDataDefinedSizeLegend::SizeClass> classes;
   classes << QgsDataDefinedSizeLegend::SizeClass( 3.,  QString( "3" ) );
@@ -129,7 +129,7 @@ void TestQgsDataDefinedSizeLegend::testCrowded()
 {
   QgsDataDefinedSizeLegend settings;
   settings.setLegendType( QgsDataDefinedSizeLegend::LegendCollapsed );
-  settings.setFont( QgsFontUtils::getStandardTestFont( QStringLiteral( "Roman" ) ) );
+  settings.setFont( QgsFontUtils::getStandardTestFont( QStringLiteral( "Bold" ) ) );
 
   QList<QgsDataDefinedSizeLegend::SizeClass> classes;
   classes << QgsDataDefinedSizeLegend::SizeClass( 2.,  QString( "2" ) );

tests/src/core/testqgslegendrenderer.cpp

@@ -770,6 +770,7 @@ void TestQgsLegendRenderer::testDataDefinedSizeCollapsed()
 
   QgsDataDefinedSizeLegend *ddsLegend = new QgsDataDefinedSizeLegend();
   ddsLegend->setLegendType( QgsDataDefinedSizeLegend::LegendCollapsed );
+  ddsLegend->setFont( QgsFontUtils::getStandardTestFont( QStringLiteral( "Bold" ) ) );
 
   QgsSingleSymbolRenderer *r = new QgsSingleSymbolRenderer( symbol );   // takes ownership
   r->setDataDefinedSizeLegend( ddsLegend );

tests/src/python/test_qgsvectorlayer.py

@@ -2249,7 +2249,6 @@ def testClone(self):
 
         diag_renderer = QgsSingleCategoryDiagramRenderer()
         diag_renderer.setAttributeLegend(False)  # true by default
-        diag_renderer.setSizeLegend(True)  # false by default
         layer.setDiagramRenderer(diag_renderer)
 
         diag_settings = QgsDiagramLayerSettings()