Skip to content

Commit 44d9682

Browse files
committed
Use set for getFields
1 parent 8aa6a4d commit 44d9682

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

python/plugins/processing/gui/ParametersPanel.py

+5-12
Original file line numberDiff line numberDiff line change
@@ -320,18 +320,11 @@ def getFields(self, layer, datatype):
320320
elif datatype == ParameterTableField.DATA_TYPE_NUMBER:
321321
fieldTypes = [QtCore.QVariant.Int, QtCore.QVariant.Double]
322322

323-
fieldNames = []
324-
fields = layer.pendingFields()
325-
if len(fieldTypes) == 0:
326-
for field in fields:
327-
if not field.name() in fieldNames:
328-
fieldNames.append(unicode(field.name()))
329-
else:
330-
for field in fields:
331-
if field.type() in fieldTypes and not field.name() \
332-
in fieldNames:
333-
fieldNames.append(unicode(field.name()))
334-
return sorted(fieldNames, cmp=locale.strcoll)
323+
fieldNames = set()
324+
for field in layer.pendingFields():
325+
if not fieldTypes or field.type() in fieldTypes:
326+
fieldNames.add(unicode(field.name()))
327+
return sorted(list(fieldNames), cmp=locale.strcoll)
335328

336329
def somethingDependsOnThisParameter(self, parent):
337330
for param in self.alg.parameters:

0 commit comments

Comments
 (0)