Skip to content

Commit

Permalink
[sipify] prevent creation of param list when not necessary
Browse files Browse the repository at this point in the history
  • Loading branch information
3nids committed Jan 13, 2018
1 parent 6d94ac9 commit 4568bcd
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 8 deletions.
1 change: 0 additions & 1 deletion python/core/qgsmaplayer.sip
Original file line number Diff line number Diff line change
Expand Up @@ -1221,7 +1221,6 @@ Set whether provider notification is connected to triggerRepaint
%Docstring
Set the notification message that triggers repaine
If refresh on notification is enabled, the notification will triggerRepaint only

if the notification message is equal to:param message:

.. versionadded:: 3.0
Expand Down
1 change: 0 additions & 1 deletion python/core/qgsvectorlayercache.sip
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ Query the layer for the features which intersect the specified rectangle.
bool isFidCached( const QgsFeatureId fid ) const;
%Docstring
Check if a certain feature id is cached.

\param fid The feature id to look for

:return: True if this id is in the cache
Expand Down
1 change: 0 additions & 1 deletion python/gui/attributetable/qgsfeaturelistmodel.sip
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ Constructor for QgsFeatureListModel

bool setDisplayExpression( const QString &expression );
%Docstring

\param expression A QgsExpression compatible string.

:return: true if the expression could be set, false if there was a parse error.
Expand Down
12 changes: 7 additions & 5 deletions scripts/sipify.pl
Original file line number Diff line number Diff line change
Expand Up @@ -166,12 +166,14 @@ sub processDoxygenLine {
# params
if ( $line =~ m/\\param / ){
$line =~ s/\s*\\param (\w+)\b/:param $1:/g;
if ( $COMMENT_PARAM_LIST == 0 )
{
$line = "\n$line";
if ( $line =~ m/^:param/ ){
if ( $COMMENT_PARAM_LIST == 0 )
{
$line = "\n$line";
}
$COMMENT_PARAM_LIST = 1;
$COMMENT_LAST_LINE_NOTE_WARNING = 0;
}
$COMMENT_PARAM_LIST = 1;
$COMMENT_LAST_LINE_NOTE_WARNING = 0;
}

if ( $line =~ m/^\s*[\\@]brief/){
Expand Down

0 comments on commit 4568bcd

Please sign in to comment.