Apply suggestions from code review

Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
qgis · Mar 31, 2021 · 46d1d23cf71dc658583f3a5bc480506afc6753be · 46d1d23
1 parent 499c5da
commit 46d1d23cf71dc658583f3a5bc480506afc6753be
Unified Split

Showing with 3 additions and 9 deletions.

+3 −9 src/gui/layout/qgslayoutviewtoolselect.cpp
diff --git a/src/gui/layout/qgslayoutviewtoolselect.cpp b/src/gui/layout/qgslayoutviewtoolselect.cpp
@@ -218,11 +218,13 @@ void QgsLayoutViewToolSelect::layoutReleaseEvent( QgsLayoutViewMouseEvent *event
   else
     itemList = layout()->items( rect, selectionMode );
 
-  bool paperItemFocused = false;
+  QgsLayoutItemPage *focusedPaperItem = nullptr;
   for ( QGraphicsItem *item : std::as_const( itemList ) )
   {
     QgsLayoutItem *layoutItem = dynamic_cast<QgsLayoutItem *>( item );
     QgsLayoutItemPage *paperItem = dynamic_cast<QgsLayoutItemPage *>( item );
+    if ( paperItem )
+        focusedPaperItem = paperItem;
 
     if ( layoutItem && !paperItem )
     {
@@ -243,14 +245,6 @@ void QgsLayoutViewToolSelect::layoutReleaseEvent( QgsLayoutViewMouseEvent *event
         }
       }
     }
-    else
-    {
-      if ( paperItem )
-      {
-        emit itemFocused( paperItem );
-        paperItemFocused = true;
-      }
-    }
   }